Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3444)

Unified Diff: chrome/browser/resources/ntp4/new_tab.js

Issue 8038035: ntp4: re-enable bookmark pane (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/ntp4/new_tab.css ('k') | chrome/browser/ui/webui/ntp/new_tab_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/ntp4/new_tab.js
diff --git a/chrome/browser/resources/ntp4/new_tab.js b/chrome/browser/resources/ntp4/new_tab.js
index e07dc22f8a700837f802f5f4040e4150338eed53..d28e407ea37c7fa005a9cd5cf46b30dc113ff317 100644
--- a/chrome/browser/resources/ntp4/new_tab.js
+++ b/chrome/browser/resources/ntp4/new_tab.js
@@ -208,11 +208,9 @@ cr.define('ntp4', function() {
chrome.send('introMessageSeen');
}
- /*
bookmarksPage = new ntp4.BookmarksPage();
appendTilePage(bookmarksPage, localStrings.getString('bookmarksPage'));
chrome.send('getBookmarksData');
- */
var serverpromo = localStrings.getString('serverpromo');
if (serverpromo) {
@@ -418,7 +416,7 @@ cr.define('ntp4', function() {
// Set the App dot names. Skip the first and last dots (Most Visited and
// Bookmarks).
var dots = dotList.getElementsByClassName('dot');
- for (var i = 1; i < dots.length - 1; ++i) {
+ for (var i = 1; i < dots.length - 2; ++i) {
dots[i].displayTitle = data.appPageNames[i - 1] || '';
}
}
@@ -449,15 +447,13 @@ cr.define('ntp4', function() {
var pageNo = Math.min(cardSlider.currentCard, tilePages.length - 1);
cardSlider.setCards(Array.prototype.slice.call(tilePages), pageNo);
switch (shownPage) {
- case templateData['bookmarks_page_id']:
case templateData['apps_page_id']:
cardSlider.selectCardByValue(
appsPages[Math.min(shownPageIndex, appsPages.length - 1)]);
break;
-/*
+ case templateData['bookmarks_page_id']:
cardSlider.selectCardByValue(bookmarksPage);
break;
-*/
case templateData['most_visited_page_id']:
cardSlider.selectCardByValue(mostVisitedPage);
break;
« no previous file with comments | « chrome/browser/resources/ntp4/new_tab.css ('k') | chrome/browser/ui/webui/ntp/new_tab_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698