tests/gcl_unittest.py - Issue 8038028: Use universal EOL conversion when calling the text editor in gcl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/gcl_unittest.py

Issue 8038028: Use universal EOL conversion when calling the text editor in gcl. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tests/gcl_unittest.py

diff --git a/tests/gcl_unittest.py b/tests/gcl_unittest.py

index 2cccc60dae9dbeab63f947b7c5912880091c00ff..e013df2e24b677e1a0ac332ce59ac90d1450143f 100755

--- a/tests/gcl_unittest.py

+++ b/tests/gcl_unittest.py

@@ -216,7 +216,7 @@ class ChangeInfoUnittest(GclTestsBase):

description = ["This is some description.", "force an extra separator."]

gcl.GetChangelistInfoFile('bleh').AndReturn('bleeeh')

gcl.os.path.exists('bleeeh').AndReturn(True)

- gcl.gclient_utils.FileRead('bleeeh', 'r').AndReturn(

+ gcl.gclient_utils.FileRead('bleeeh').AndReturn(

gcl.ChangeInfo._SEPARATOR.join(["42, 53", "G b.cc"] + description))

gcl.GetCodeReviewSetting('CODE_REVIEW_SERVER').AndReturn('foo')

# Does an upgrade.

@@ -236,7 +236,7 @@ class ChangeInfoUnittest(GclTestsBase):

self.mox.StubOutWithMock(gcl, 'GetCodeReviewSetting')