Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 8038019: Adapt linux-tick-processor to GYP build. (Closed)

Created:
9 years, 2 months ago by Yang
Modified:
9 years, 2 months ago
CC:
v8-dev
Visibility:
Public.

Description

Adapt linux-tick-processor to GYP build. Committed: http://code.google.com/p/v8/source/detail?r=9429

Patch Set 1 #

Patch Set 2 : Updated error message. #

Patch Set 3 : Added out/native/ #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -12 lines) Patch
M tools/linux-tick-processor View 1 2 2 chunks +19 lines, -12 lines 2 comments Download

Messages

Total messages: 3 (0 generated)
Yang
When using the GYP build, linux-tick-processor script fails to find d8. With this patch, we ...
9 years, 2 months ago (2011-09-26 13:53:10 UTC) #1
mnaganov (inactive)
On 2011/09/26 13:53:10, Yang wrote: > When using the GYP build, linux-tick-processor script fails to ...
9 years, 2 months ago (2011-09-26 13:56:18 UTC) #2
Jakob Kummerow
9 years, 2 months ago (2011-09-26 14:08:35 UTC) #3
LGTM.

Another idea if this turns out to be not flexible enough would be a
--shell=path/to/d8 parameter as some of our other scripts have.

Powered by Google App Engine
This is Rietveld 408576698