Source/WebCore/html/HTMLEmbedElement.cpp - Issue 8037052: Merge 95204 - 2011-09-15 James Simonsen <simonjam@chromium.org>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/WebCore/html/HTMLEmbedElement.cpp

Issue 8037052: Merge 95204 - 2011-09-15 James Simonsen <simonjam@chromium.org> (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/835/

Patch Set: Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/plugins/destroy-during-npp-new-object-with-fallback-content-expected.txt ('k') | Source/WebCore/html/HTMLObjectElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/WebCore/html/HTMLEmbedElement.cpp

===================================================================

--- Source/WebCore/html/HTMLEmbedElement.cpp (revision 96031)

+++ Source/WebCore/html/HTMLEmbedElement.cpp (working copy)

@@ -178,6 +178,7 @@

return;

}

+ RefPtr<HTMLEmbedElement> protect(this); // Loading the plugin might remove us from the document.

SubframeLoader* loader = document()->frame()->loader()->subframeLoader();

// FIXME: beforeLoad could have detached the renderer! Just like in the <object> case above.

loader->requestObject(this, m_url, getAttribute(nameAttr), m_serviceType, paramNames, paramValues);