[ChromeOS] Auto reload auth extension.

[ChromeOS] Auto reload auth extension.

Auto reload auth extension when we hit frame error and we are online. Retry three times with 5s, 10s and 20s delays.

Also add more logs to find out whether the offline/portal message is being shown.

BUG=chromium-os:20323
TEST=Verify fix for chromium-os:20323.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=103057

[zel, 2011-09-26 21:15:07]

* 1, 2 then 4 seems bit too aggressive, but I am ok if we put this in first and
see how things look like.

* you should probably check if online portal is detected here as well - there is
no reason to retry if we believe that we are behind a captive portal

[xiyuan, 2011-09-26 21:27:25]

On 2011/09/26 21:15:07, zel wrote:
> * 1, 2 then 4 seems bit too aggressive, but I am ok if we put this in first
and
> see how things look like.
> 
How about 5, 10, 20 then?

> * you should probably check if online portal is detected here as well - there
is
> no reason to retry if we believe that we are behind a captive portal
Right now, we don't know the portal status. Alexy has a CL
http://codereview.chromium.org/8043024/ that would bring in portal state into
js. I could wait and merge with his change.

[zel, 2011-09-26 21:30:38]

5,10,20 sounds more reasonable



On Mon, Sep 26, 2011 at 2:27 PM, <xiyuan@chromium.org> wrote:

> On 2011/09/26 21:15:07, zel wrote:
>
>> * 1, 2 then 4 seems bit too aggressive, but I am ok if we put this in
>> first
>>
> and
>
>> see how things look like.
>>
>
> How about 5, 10, 20 then?
>
>
>  * you should probably check if online portal is detected here as well -
>> there
>>
> is
>
>> no reason to retry if we believe that we are behind a captive portal
>>
> Right now, we don't know the portal status. Alexy has a CL
>
http://codereview.chromium.**org/8043024/<http://codereview.chromium.org/8043...
would bring in portal state into
> js. I could wait and merge with his change.
>
>
>
http://codereview.chromium.**org/8037035/<http://codereview.chromium.org/8037...
>

[xiyuan, 2011-09-26 22:24:05]

+altimofeev

This CL needs portal state from CL: http://codereview.chromium.org/8043024/

[xiyuan, 2011-09-27 18:19:51]

Merged with 8043024 and we only retry when we are online (i.e. not in a portal).

[zel, 2011-09-27 22:36:47]

LGTM

http://codereview.chromium.org/8037035/diff/6001/chrome/browser/resources/chr...
File chrome/browser/resources/chromeos/login/screen_offline_message.js (right):

http://codereview.chromium.org/8037035/diff/6001/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/login/screen_offline_message.js:71: var
isOnline = state == NET_STATE.ONLINE;
nit: put brackets around this expression

http://codereview.chromium.org/8037035/diff/6001/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/login/screen_offline_message.js:72: var
isUnderCaptivePortal = state == NET_STATE.PORTAL;
same

[xiyuan, 2011-09-27 22:42:25]

http://codereview.chromium.org/8037035/diff/6001/chrome/browser/resources/chr...
File chrome/browser/resources/chromeos/login/screen_offline_message.js (right):

http://codereview.chromium.org/8037035/diff/6001/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/login/screen_offline_message.js:71: var
isOnline = state == NET_STATE.ONLINE;
On 2011/09/27 22:36:47, zel wrote:
> nit: put brackets around this expression

Done.

http://codereview.chromium.org/8037035/diff/6001/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/login/screen_offline_message.js:72: var
isUnderCaptivePortal = state == NET_STATE.PORTAL;
On 2011/09/27 22:36:47, zel wrote:
> same

Done.

[commit-bot: I haz the power, 2011-09-27 22:42:39]

CQ is trying tha patch. Follow status at
https://chromium-status.appspot.com/cq/xiyuan@chromium.org/8037035/10001

[commit-bot: I haz the power, 2011-09-28 00:07:34]

Change committed as 103057