Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 8037014: Get gid of created folders from stat()ing the folders, not from getgid(). (Closed)

Created:
9 years, 3 months ago by Sam Kerner (Chrome)
Modified:
9 years, 2 months ago
Reviewers:
Nico, brettw
CC:
chromium-reviews, brettw-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Get gid of created folders from stat()ing the folders, not from getgid(). BUG=97876 TEST=VerifyPathControlledByUserTest.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102748

Patch Set 1 #

Patch Set 2 : Re-enable tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -34 lines) Patch
M base/file_util_unittest.cc View 1 5 chunks +9 lines, -34 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Sam Kerner (Chrome)
9 years, 3 months ago (2011-09-24 22:51:25 UTC) #1
Nico
LGTM, thanks! Do you want to revert r102662 as part of this CL as well?
9 years, 3 months ago (2011-09-24 22:55:00 UTC) #2
Sam Kerner (Chrome)
On 2011/09/24 22:55:00, Nico wrote: > LGTM, thanks! > > Do you want to revert ...
9 years, 3 months ago (2011-09-25 00:35:39 UTC) #3
Sam Kerner (Chrome)
Adding Evan, whose OWNERS powers are required for base/ .
9 years, 2 months ago (2011-09-26 14:26:03 UTC) #4
Nico
On 2011/09/26 14:26:03, Sam Kerner (Chrome) wrote: > Adding Evan, whose OWNERS powers are required ...
9 years, 2 months ago (2011-09-26 16:31:35 UTC) #5
Sam Kerner (Chrome)
On 2011/09/26 16:31:35, Nico wrote: > On 2011/09/26 14:26:03, Sam Kerner (Chrome) wrote: > > ...
9 years, 2 months ago (2011-09-26 16:55:58 UTC) #6
brettw
9 years, 2 months ago (2011-09-26 17:11:21 UTC) #7
LGTM stubber ramp

Powered by Google App Engine
This is Rietveld 408576698