Issue 8036047: In 32bit mode, removed all assembly addressing modes that are incompatible with

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8036047: In 32bit mode, removed all assembly addressing modes that are incompatible with (Closed)

Created:
9 years, 2 months ago by Markus (顧孟勤)

Modified:
9 years, 2 months ago

Reviewers:
agl

CC:
chromium-reviews, Markus (顧孟勤), Mark Seaborn

Base URL:
http://seccompsandbox.googlecode.com/svn/trunk/

Visibility:
Public.

Description

In 32bit mode, removed all assembly addressing modes that are incompatible with position independent code. Fedora is configured to refuse running binaries that require relocations. TEST=add -fPIC and -fPIE to CFLAGS and LDFLAGS respectively, then run "scanelf -qT ./preload32.so". There shouldn't be any output. BUG=http://code.google.com/p/chromium/issues/detail?id=87704 Committed: http://code.google.com/p/seccompsandbox/source/detail?r=170

Patch Set 1 #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+185 lines, -146 lines)			Patch
M	fault_handler_i386.S	View	7 chunks	+89 lines, -77 lines	0 comments	Download
M	sigaction.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	syscall_entrypoint.cc	View	7 chunks	+44 lines, -30 lines	0 comments	Download
M	test.cc	View	1 chunk	+7 lines, -6 lines	0 comments	Download
M	trusted_thread_i386.S	View	16 chunks	+43 lines, -30 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM. Thanks for doing this so quickly.

Expand Messages | Collapse Messages