Issue 8036046: Revert r102783 "Support for |change| argument to |GetPreferredTrySlaves()|."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8036046: Revert r102783 "Support for |change| argument to |GetPreferredTrySlaves()|." (Closed)

Created:
9 years, 2 months ago by M-A Ruel

Modified:
9 years, 2 months ago

Reviewers:
commit-bot: I haz the power

CC:
chromium-reviews, Dirk Pranke, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Revert r102783 "Support for |change| argument to |GetPreferredTrySlaves()|." Cause an infinite recursion in some context. TBR=asvitkine@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102836

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+70 lines, -138 lines)			Patch
M	gcl.py	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	git_cl.py	View	3 chunks	+3 lines, -6 lines	0 comments	Download
M	git_try.py	View	2 chunks	+1 line, -4 lines	0 comments	Download
M	presubmit_support.py	View	6 chunks	+8 lines, -14 lines	0 comments	Download
M	tests/presubmit_unittest.py	View	5 chunks	+11 lines, -34 lines	0 comments	Download
M	tests/trychange_unittest.py	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	trychange.py	View	9 chunks	+43 lines, -67 lines	0 comments	Download

Total messages: 3 (0 generated)

commit-bot: I haz the power

CQ is trying tha patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/8036046/1

9 years, 2 months ago (2011-09-27 00:06:49 UTC) #2

Change committed as 102836