Issue 8036024: Add ObjectMoveEvent reporting for the Heap Profiler into MarkCompact.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8036024: Add ObjectMoveEvent reporting for the Heap Profiler into MarkCompact. (Closed)

Created:
9 years, 2 months ago by mnaganov (inactive)

Modified:
9 years, 2 months ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Add ObjectMoveEvent reporting for the Heap Profiler into MarkCompact. R=vegorov@chromium.org BUG=none TEST=none Committed: http://code.google.com/p/v8/source/detail?r=9432

Patch Set 2 : Fix typo #

Total comments: 2

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -4 lines)			Patch
	M	src/mark-compact.cc	View		1 chunk	+1 line, -0 lines	2 comments	Download
	M	src/profile-generator.cc	View	1	1 chunk	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Chromium)

LGTM http://codereview.chromium.org/8036024/diff/2001/src/mark-compact.cc File src/mark-compact.cc (right): http://codereview.chromium.org/8036024/diff/2001/src/mark-compact.cc#newcode2370 src/mark-compact.cc:2370: HEAP_PROFILE(heap(), ObjectMoveEvent(src, dst)); For code objects do you ...

9 years, 2 months ago (2011-09-26 15:52:00 UTC) #2

mnaganov (inactive)

9 years, 2 months ago (2011-09-26 15:58:23 UTC) #3

Thank you!

http://codereview.chromium.org/8036024/diff/2001/src/mark-compact.cc
File src/mark-compact.cc (right):

http://codereview.chromium.org/8036024/diff/2001/src/mark-compact.cc#newcode2370
src/mark-compact.cc:2370: HEAP_PROFILE(heap(), ObjectMoveEvent(src, dst));
On 2011/09/26 15:52:00, Vyacheslav Egorov wrote:
> For code objects do you expect to get both ObjectMoveEvent and CodeMoveEvent?
> (send on line 2407)

Yes, because CPU and Heap profilers are independent.

Expand Messages | Collapse Messages

Issue 8036024: Add ObjectMoveEvent reporting for the Heap Profiler into MarkCompact. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fix typo #

Messages