Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 8036016: Updated spdy_framer.cc with the latest code. (Closed)

Created:
9 years, 3 months ago by ramant (doing other things)
Modified:
9 years, 2 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Updated spdy_framer.cc with the latest code. Code for PING was added. TEST=spdy unit testsR=willchan Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102707

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+783 lines, -56 lines) Patch
M net/spdy/spdy_framer.h View 1 2 13 chunks +128 lines, -12 lines 0 comments Download
M net/spdy/spdy_framer.cc View 1 2 26 chunks +544 lines, -42 lines 0 comments Download
M net/spdy/spdy_framer_test.cc View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
M net/spdy/spdy_protocol.h View 1 2 6 chunks +67 lines, -1 line 0 comments Download
M net/spdy/spdy_session.h View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M net/spdy/spdy_session.cc View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
M net/tools/flip_server/spdy_interface.h View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M net/tools/flip_server/spdy_interface.cc View 1 2 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ramant (doing other things)
Hi willchan, Would appreciate if you could take a look at these changes. thanks much, ...
9 years, 3 months ago (2011-09-25 05:03:40 UTC) #1
willchan no longer on Chromium
LGTM, feel free to commit. I had a question which I asked on the other ...
9 years, 2 months ago (2011-09-25 22:18:23 UTC) #2
ramant (doing other things)
Deleted the comment line. thanks http://codereview.chromium.org/8036016/diff/5002/net/spdy/spdy_framer.cc File net/spdy/spdy_framer.cc (right): http://codereview.chromium.org/8036016/diff/5002/net/spdy/spdy_framer.cc#newcode785 net/spdy/spdy_framer.cc:785: // LOG(DFATAL) << "DATA_FLAG_COMPRESSED ...
9 years, 2 months ago (2011-09-26 00:27:54 UTC) #3
commit-bot: I haz the power
CQ is trying tha patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/8036016/3006
9 years, 2 months ago (2011-09-26 04:36:05 UTC) #4
commit-bot: I haz the power
9 years, 2 months ago (2011-09-26 08:45:21 UTC) #5
Change committed as 102707

Powered by Google App Engine
This is Rietveld 408576698