Issue 8036008: Linux: add a missing check for /usr/local/bin/gold/ld.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8036008: Linux: add a missing check for /usr/local/bin/gold/ld. (Closed)

Created:
9 years, 3 months ago by Lei Zhang

Modified:
9 years, 2 months ago

Reviewers:
Michael Moss

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Linux: add a missing check for /usr/local/bin/gold/ld. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102860

Patch Set 1 #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -5 lines)			Patch
	M	build/install-build-deps.sh	View		1 chunk	+8 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

TBR (need to commit something to kick the bots and this seems pretty safe)

9 years, 2 months ago (2011-09-27 01:56:56 UTC) #2

Michael Moss

9 years, 2 months ago (2011-09-27 03:04:23 UTC) #3

LGTM

Sorry, I lost the initial review mail somehow.
On Sep 26, 2011 6:56 PM, <thestig@chromium.org> wrote:
> TBR (need to commit something to kick the bots and this seems pretty safe)
>
> http://codereview.chromium.org/8036008/

Expand Messages | Collapse Messages