Delegate decision what site instances can be rendered in what process to chrome

content/browser/site_instance_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/compiler_specific.h"
 #include "base/stl_util.h"
 #include "base/string16.h"
-#include "chrome/test/base/testing_profile.h"
 #include "content/browser/browser_thread.h"
 #include "content/browser/browsing_instance.h"
 #include "content/browser/child_process_security_policy.h"
 #include "content/browser/mock_content_browser_client.h"
 #include "content/browser/renderer_host/browser_render_process_host.h"
 #include "content/browser/renderer_host/render_view_host.h"
 #include "content/browser/renderer_host/test_render_view_host.h"
 #include "content/browser/site_instance.h"
 #include "content/browser/tab_contents/navigation_entry.h"
 #include "content/browser/tab_contents/tab_contents.h"
 #include "content/browser/webui/empty_web_ui_factory.h"
 #include "content/common/content_client.h"
 #include "content/common/content_constants.h"
 #include "content/common/url_constants.h"
+#include "content/test/test_browser_context.h"
+#include "googleurl/src/url_util.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace {
 
 const char kSameAsAnyInstanceURL[] = "about:internets";
 
+const char kPrivilegedScheme[] = "privileged";
+
 class SiteInstanceTestWebUIFactory : public content::EmptyWebUIFactory {
  public:
   virtual bool UseWebUIForURL(content::BrowserContext* browser_context,
                               const GURL& url) const OVERRIDE {
     return HasWebUIScheme(url);
   }
   virtual bool HasWebUIScheme(const GURL& url) const OVERRIDE {
     return url.SchemeIs(chrome::kChromeUIScheme);
   }
 };
 
 class SiteInstanceTestBrowserClient : public content::MockContentBrowserClient {
  public:
-  SiteInstanceTestBrowserClient() : old_browser_client_(NULL) {
+  SiteInstanceTestBrowserClient()
+      : old_browser_client_(NULL),
+        privileged_process_id_(-1) {
   }
 
   virtual TabContentsView* CreateTabContentsView(TabContents* tab_contents) {
     return old_browser_client_->CreateTabContentsView(tab_contents);
   }
 
   virtual content::WebUIFactory* GetWebUIFactory() OVERRIDE {
     return &factory_;
   }
 
   virtual bool ShouldUseProcessPerSite(content::BrowserContext* browser_context,
                                        const GURL& effective_url) OVERRIDE {
     return false;
   }
 
   virtual bool IsURLSameAsAnySiteInstance(const GURL& url) OVERRIDE {
     return url == GURL(kSameAsAnyInstanceURL) ||
            url == GURL(chrome::kAboutCrashURL);
   }
 
+  virtual bool IsSuitableHost(RenderProcessHost* process_host,
+                              const GURL& site_url) OVERRIDE {
+    return (privileged_process_id_ == process_host->id()) ==
+        site_url.SchemeIs(kPrivilegedScheme);
+  }
+
   virtual GURL GetEffectiveURL(content::BrowserContext* browser_context,
                                const GURL& url) OVERRIDE {
     return url;
   }
 
   void SetOriginalClient(content::ContentBrowserClient* old_browser_client) {
     old_browser_client_ = old_browser_client;
   }
 
+  void SetPrivilegedProcessId(int process_id) {
+    privileged_process_id_ = process_id;
+  }
+
  private:
   SiteInstanceTestWebUIFactory factory_;
   content::ContentBrowserClient* old_browser_client_;
+  int privileged_process_id_;
 };
 
 class SiteInstanceTest : public testing::Test {
  public:
   SiteInstanceTest()
       : ui_thread_(BrowserThread::UI, &message_loop_),
         old_browser_client_(NULL) {
   }
 
   virtual void SetUp() {
     old_browser_client_ = content::GetContentClient()->browser();
     browser_client_.SetOriginalClient(old_browser_client_);
     content::GetContentClient()->set_browser(&browser_client_);
+    url_util::AddStandardScheme(kPrivilegedScheme);
+    url_util::AddStandardScheme(chrome::kChromeUIScheme);
   }
 
   virtual void TearDown() {
     content::GetContentClient()->set_browser(old_browser_client_);
   }
 
+  void SetPrivilegedProcessId(int process_id) {
+    browser_client_.SetPrivilegedProcessId(process_id);
+  }
+
  private:
   MessageLoopForUI message_loop_;
   BrowserThread ui_thread_;
 
   SiteInstanceTestBrowserClient browser_client_;
   content::ContentBrowserClient* old_browser_client_;
 };
 
 class TestBrowsingInstance : public BrowsingInstance {
  public:
-  TestBrowsingInstance(Profile* profile, int* deleteCounter)
-      : BrowsingInstance(profile),
+  TestBrowsingInstance(content::BrowserContext* browser_context,
+                       int* deleteCounter)
+      : BrowsingInstance(browser_context),
         use_process_per_site(false),
         deleteCounter_(deleteCounter) {
   }
 
   // Overrides BrowsingInstance::ShouldUseProcessPerSite so that we can test
   // both alternatives without using command-line switches.
   bool ShouldUseProcessPerSite(const GURL& url) {
     return use_process_per_site;
   }
 
   // Set by individual tests.
   bool use_process_per_site;
 
  private:
   ~TestBrowsingInstance() {
     (*deleteCounter_)++;
   }
 
   int* deleteCounter_;
 };
 
 class TestSiteInstance : public SiteInstance {
  public:
-  static TestSiteInstance* CreateTestSiteInstance(Profile* profile,
-                                                  int* siteDeleteCounter,
-                                                  int* browsingDeleteCounter) {
+  static TestSiteInstance* CreateTestSiteInstance(
+      content::BrowserContext* browser_context,
+      int* siteDeleteCounter,
+      int* browsingDeleteCounter) {
     TestBrowsingInstance* browsing_instance =
-        new TestBrowsingInstance(profile, browsingDeleteCounter);
+        new TestBrowsingInstance(browser_context, browsingDeleteCounter);
     return new TestSiteInstance(browsing_instance, siteDeleteCounter);
   }
 
  private:
   TestSiteInstance(BrowsingInstance* browsing_instance, int* deleteCounter)
     : SiteInstance(browsing_instance), deleteCounter_(deleteCounter) {}
   ~TestSiteInstance() {
     (*deleteCounter_)++;
   }
 
@@ skipping 35 matching lines @@
   delete e1;
   EXPECT_EQ(0, siteDeleteCounter);
   EXPECT_EQ(0, browsingDeleteCounter);
   delete e2;
   EXPECT_EQ(1, siteDeleteCounter);
   // instance is now deleted
   EXPECT_EQ(1, browsingDeleteCounter);
   // browsing_instance is now deleted
 
   // Ensure that instances are deleted when their RenderViewHosts are gone.
-  scoped_ptr<TestingProfile> profile(new TestingProfile());
+  scoped_ptr<TestBrowserContext> browser_context(new TestBrowserContext());
   instance =
-      TestSiteInstance::CreateTestSiteInstance(profile.get(),
+      TestSiteInstance::CreateTestSiteInstance(browser_context.get(),
                                                &siteDeleteCounter,
                                                &browsingDeleteCounter);
   {
-    TabContents contents(profile.get(), instance, MSG_ROUTING_NONE, NULL, NULL);
+    TabContents contents(browser_context.get(),
+                         instance,
+                         MSG_ROUTING_NONE,
+                         NULL,
+                         NULL);
     EXPECT_EQ(1, siteDeleteCounter);
     EXPECT_EQ(1, browsingDeleteCounter);
   }
 
   // Make sure that we flush any messages related to the above TabContents
   // destruction.
   MessageLoop::current()->RunAllPending();
 
   EXPECT_EQ(2, siteDeleteCounter);
   EXPECT_EQ(2, browsingDeleteCounter);
@@ skipping 47 matching lines @@
 
   // Make sure max_page_id_ is monotonically increasing.
   instance->UpdateMaxPageID(3);
   instance->UpdateMaxPageID(1);
   EXPECT_EQ(3, instance->max_page_id());
 }
 
 // Test to ensure GetProcess returns and creates processes correctly.
 TEST_F(SiteInstanceTest, GetProcess) {
   // Ensure that GetProcess returns a process.
-  scoped_ptr<TestingProfile> profile(new TestingProfile());
+  scoped_ptr<TestBrowserContext> browser_context(new TestBrowserContext());
   scoped_ptr<RenderProcessHost> host1;
   scoped_refptr<SiteInstance> instance(
-      SiteInstance::CreateSiteInstance(profile.get()));
+      SiteInstance::CreateSiteInstance(browser_context.get()));
   host1.reset(instance->GetProcess());
   EXPECT_TRUE(host1.get() != NULL);
 
   // Ensure that GetProcess creates a new process.
   scoped_refptr<SiteInstance> instance2(
-      SiteInstance::CreateSiteInstance(profile.get()));
+      SiteInstance::CreateSiteInstance(browser_context.get()));
   scoped_ptr<RenderProcessHost> host2(instance2->GetProcess());
   EXPECT_TRUE(host2.get() != NULL);
   EXPECT_NE(host1.get(), host2.get());
 }
 
 // Test to ensure SetSite and site() work properly.
 TEST_F(SiteInstanceTest, SetSite) {
   scoped_refptr<SiteInstance> instance(SiteInstance::CreateSiteInstance(NULL));
   EXPECT_FALSE(instance->has_site());
   EXPECT_TRUE(instance->site().is_empty());
@@ skipping 92 matching lines @@
             site_instance_a1->GetRelatedSiteInstance(url_b1));
 
   // A second visit to the original site should return the same SiteInstance.
   const GURL url_a2("http://www.google.com/2.html");
   EXPECT_EQ(site_instance_a1.get(),
             browsing_instance->GetSiteInstanceForURL(url_a2));
   EXPECT_EQ(site_instance_a1.get(),
             site_instance_a1->GetRelatedSiteInstance(url_a2));
 
   // A visit to the original site in a new BrowsingInstance (same or different
-  // profile) should return a different SiteInstance.
+  // browser context) should return a different SiteInstance.
   TestBrowsingInstance* browsing_instance2 =
       new TestBrowsingInstance(NULL, &deleteCounter);
   browsing_instance2->use_process_per_site = false;
   // Ensure the new SiteInstance is ref counted so that it gets deleted.
   scoped_refptr<SiteInstance> site_instance_a2_2(
       browsing_instance2->GetSiteInstanceForURL(url_a2));
   EXPECT_NE(site_instance_a1.get(), site_instance_a2_2.get());
 
   // Should be able to see that we do have SiteInstances.
   EXPECT_TRUE(browsing_instance->HasSiteInstance(
       GURL("http://mail.google.com")));
   EXPECT_TRUE(browsing_instance2->HasSiteInstance(
       GURL("http://mail.google.com")));
   EXPECT_TRUE(browsing_instance->HasSiteInstance(
       GURL("http://mail.yahoo.com")));
 
   // Should be able to see that we don't have SiteInstances.
   EXPECT_FALSE(browsing_instance->HasSiteInstance(
       GURL("https://www.google.com")));
   EXPECT_FALSE(browsing_instance2->HasSiteInstance(
       GURL("http://www.yahoo.com")));
 
   // browsing_instances will be deleted when their SiteInstances are deleted
 }
 
 // Test to ensure that there is only one SiteInstance per site for an entire
-// Profile, if process-per-site is in use.
-TEST_F(SiteInstanceTest, OneSiteInstancePerSiteInProfile) {
+// BrowserContext, if process-per-site is in use.
+TEST_F(SiteInstanceTest, OneSiteInstancePerSiteInBrowserContext) {
   int deleteCounter = 0;
   TestBrowsingInstance* browsing_instance =
       new TestBrowsingInstance(NULL, &deleteCounter);
   browsing_instance->use_process_per_site = true;
 
   const GURL url_a1("http://www.google.com/1.html");
   scoped_refptr<SiteInstance> site_instance_a1(
       browsing_instance->GetSiteInstanceForURL(url_a1));
   EXPECT_TRUE(site_instance_a1.get() != NULL);
 
   // A separate site should create a separate SiteInstance.
   const GURL url_b1("http://www.yahoo.com/");
   scoped_refptr<SiteInstance> site_instance_b1(
       browsing_instance->GetSiteInstanceForURL(url_b1));
   EXPECT_NE(site_instance_a1.get(), site_instance_b1.get());
 
   // Getting the new SiteInstance from the BrowsingInstance and from another
   // SiteInstance in the BrowsingInstance should give the same result.
   EXPECT_EQ(site_instance_b1.get(),
             site_instance_a1->GetRelatedSiteInstance(url_b1));
 
   // A second visit to the original site should return the same SiteInstance.
   const GURL url_a2("http://www.google.com/2.html");
   EXPECT_EQ(site_instance_a1.get(),
             browsing_instance->GetSiteInstanceForURL(url_a2));
   EXPECT_EQ(site_instance_a1.get(),
             site_instance_a1->GetRelatedSiteInstance(url_a2));
 
-  // A visit to the original site in a new BrowsingInstance (same profile)
-  // should also return the same SiteInstance.
+  // A visit to the original site in a new BrowsingInstance (same browser
+  // context) should also return the same SiteInstance.
   // This BrowsingInstance doesn't get its own SiteInstance within the test, so
   // it won't be deleted by its children.  Thus, we'll keep a ref count to it
   // to make sure it gets deleted.
   scoped_refptr<TestBrowsingInstance> browsing_instance2(
       new TestBrowsingInstance(NULL, &deleteCounter));
   browsing_instance2->use_process_per_site = true;
   EXPECT_EQ(site_instance_a1.get(),
             browsing_instance2->GetSiteInstanceForURL(url_a2));
 
-  // A visit to the original site in a new BrowsingInstance (different profile)
-  // should return a different SiteInstance.
-  scoped_ptr<TestingProfile> profile(new TestingProfile());
+  // A visit to the original site in a new BrowsingInstance (different browser
+  // context) should return a different SiteInstance.
+  scoped_ptr<TestBrowserContext> browser_context(new TestBrowserContext());
   TestBrowsingInstance* browsing_instance3 =
-      new TestBrowsingInstance(profile.get(), &deleteCounter);
+      new TestBrowsingInstance(browser_context.get(), &deleteCounter);
   browsing_instance3->use_process_per_site = true;
   // Ensure the new SiteInstance is ref counted so that it gets deleted.
   scoped_refptr<SiteInstance> site_instance_a2_3(
       browsing_instance3->GetSiteInstanceForURL(url_a2));
   EXPECT_NE(site_instance_a1.get(), site_instance_a2_3.get());
 
   // Should be able to see that we do have SiteInstances.
   EXPECT_TRUE(browsing_instance->HasSiteInstance(
       GURL("http://mail.google.com")));  // visited before
   EXPECT_TRUE(browsing_instance2->HasSiteInstance(
       GURL("http://mail.google.com")));  // visited before
   EXPECT_TRUE(browsing_instance->HasSiteInstance(
       GURL("http://mail.yahoo.com")));  // visited before
   EXPECT_TRUE(browsing_instance2->HasSiteInstance(
-      GURL("http://www.yahoo.com")));  // different BI, but same profile
+      GURL("http://www.yahoo.com")));  // different BI, but same browser context
 
   // Should be able to see that we don't have SiteInstances.
   EXPECT_FALSE(browsing_instance->HasSiteInstance(
       GURL("https://www.google.com")));  // not visited before
   EXPECT_FALSE(browsing_instance3->HasSiteInstance(
-      GURL("http://www.yahoo.com")));  // different BI, different profile
+      GURL("http://www.yahoo.com")));  // different BI, different context
 
   // browsing_instances will be deleted when their SiteInstances are deleted
 }
 
 static SiteInstance* CreateSiteInstance(RenderProcessHostFactory* factory,
                                         const GURL& url) {
   SiteInstance* instance = SiteInstance::CreateSiteInstanceForURL(NULL, url);
   instance->set_render_process_host_factory(factory);
   return instance;
 }
 
 // Test to ensure that pages that require certain privileges are grouped
 // in processes with similar pages.
 TEST_F(SiteInstanceTest, ProcessSharingByType) {
   MockRenderProcessHostFactory rph_factory;
   ChildProcessSecurityPolicy* policy =
       ChildProcessSecurityPolicy::GetInstance();
 
   // Make a bunch of mock renderers so that we hit the limit.
   std::vector<MockRenderProcessHost*> hosts;
   for (size_t i = 0; i < content::kMaxRendererProcessCount; ++i)
     hosts.push_back(new MockRenderProcessHost(NULL));
 
   // Create some extension instances and make sure they share a process.
   scoped_refptr<SiteInstance> extension1_instance(
-      CreateSiteInstance(&rph_factory, GURL("chrome-extension://foo/bar")));
-  policy->GrantExtensionBindings(extension1_instance->GetProcess()->id());
+      CreateSiteInstance(&rph_factory,
+      GURL(kPrivilegedScheme + std::string("://foo/bar"))));
+  SetPrivilegedProcessId(extension1_instance->GetProcess()->id());
 
   scoped_refptr<SiteInstance> extension2_instance(
-      CreateSiteInstance(&rph_factory, GURL("chrome-extension://baz/bar")));
+      CreateSiteInstance(&rph_factory,
+      GURL(kPrivilegedScheme + std::string("://baz/bar"))));
 
   scoped_ptr<RenderProcessHost> extension_host(
       extension1_instance->GetProcess());
   EXPECT_EQ(extension1_instance->GetProcess(),
             extension2_instance->GetProcess());
 
   // Create some WebUI instances and make sure they share a process.
   scoped_refptr<SiteInstance> webui1_instance(CreateSiteInstance(&rph_factory,
       GURL(chrome::kChromeUIScheme + std::string("://newtab"))));
   policy->GrantWebUIBindings(webui1_instance->GetProcess()->id());
 
   scoped_refptr<SiteInstance> webui2_instance( CreateSiteInstance(&rph_factory,
       GURL(chrome::kChromeUIScheme + std::string("://history"))));
 
   scoped_ptr<RenderProcessHost> dom_host(webui1_instance->GetProcess());
   EXPECT_EQ(webui1_instance->GetProcess(), webui2_instance->GetProcess());
 
   // Make sure none of differing privilege processes are mixed.
   EXPECT_NE(extension1_instance->GetProcess(), webui1_instance->GetProcess());
 
   for (size_t i = 0; i < content::kMaxRendererProcessCount; ++i) {
     EXPECT_NE(extension1_instance->GetProcess(), hosts[i]);
     EXPECT_NE(webui1_instance->GetProcess(), hosts[i]);
   }
 
   STLDeleteContainerPointers(hosts.begin(), hosts.end());
 }