Delegate decision what site instances can be rendered in what process to chrome

chrome/browser/chrome_content_browser_client.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chrome_content_browser_client.h"
 
 #include "base/command_line.h"
 #include "chrome/app/breakpad_mac.h"
 #include "chrome/browser/browser_about_handler.h"
 #include "chrome/browser/browser_process.h"
@@ skipping 229 matching lines @@
   return true;
 }
 
 bool ChromeContentBrowserClient::IsURLSameAsAnySiteInstance(const GURL& url) {
   return url == GURL(chrome::kChromeUICrashURL) ||
          url == GURL(chrome::kChromeUIKillURL) ||
          url == GURL(chrome::kChromeUIHangURL) ||
          url == GURL(chrome::kChromeUIShorthangURL);
 }
 
+bool ChromeContentBrowserClient::IsSuitableHost(
+    RenderProcessHost* process_host,
+    const GURL& site_url) {
+  Profile* profile =
+      Profile::FromBrowserContext(process_host->browser_context());
+  ExtensionProcessManager* process_manager =

[Aaron Boodman, 2011/09/27 19:26:49]

Nit: I would prefer to call this variable extension_process_manager, even though
it is longer. While reading the code, I kept forgetting that's what it was.

[jochen (gone - plz use gerrit), 2011/09/27 20:41:40]

Done.

+      profile->GetExtensionProcessManager();
+
+  // Maybe NULL during tests.
+  if (!process_manager)
+    return true;
+
+  bool is_extension_host =
+      process_host->is_extension_process() ||

[Aaron Boodman, 2011/09/27 19:26:49]

Eventually, this field is going to have to go. Will your design be able to
replace it?

[jochen (gone - plz use gerrit), 2011/09/27 20:41:40]

currently this flag is set and queried only in chrome/ (with one exception in
browser render process host where based on this flag UMA metrics and the command
line of the browser are set, but both can be handled on the chrome/ site as well
I think)

So the plan is to register processes that have this flag with the EPM as well,
and query the EPM form everywhere in chrome/ where this flag is read.

+      process_manager->IsProcessHostWithBindings(process_host->id());
+  return site_url.SchemeIs(chrome::kExtensionScheme) == is_extension_host;
+}
+
 std::string ChromeContentBrowserClient::GetCanonicalEncodingNameByAliasName(
     const std::string& alias_name) {
   return CharacterEncoding::GetCanonicalEncodingNameByAliasName(alias_name);
 }
 
 void ChromeContentBrowserClient::AppendExtraCommandLineSwitches(
     CommandLine* command_line, int child_process_id) {
 #if defined(USE_LINUX_BREAKPAD)
   if (IsCrashReporterEnabled()) {
     command_line->AppendSwitchASCII(switches::kEnableCrashReporter,
@@ skipping 553 matching lines @@
 #if defined(USE_NSS)
 crypto::CryptoModuleBlockingPasswordDelegate*
     ChromeContentBrowserClient::GetCryptoPasswordDelegate(
         const GURL& url) {
   return browser::NewCryptoModuleBlockingDialogDelegate(
       browser::kCryptoModulePasswordKeygen, url.host());
 }
 #endif
 
 }  // namespace chrome