Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 8028026: Refactor JSObject::SetFastElement. (Closed)

Created:
9 years, 2 months ago by Jakob Kummerow
Modified:
9 years, 2 months ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

Refactor JSObject::SetFastElement. This fixes a bug where the length of FAST_DOUBLE_ELEMENTS arrays was not set correctly, and another bug where appending a double element to a SMI_ONLY array would convert it to FAST_ELEMENTS instead of FAST_DOUBLE_ELEMENTS. Committed: http://code.google.com/p/v8/source/detail?r=9533

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -53 lines) Patch
M src/objects.cc View 2 chunks +61 lines, -53 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Jakob Kummerow
PTAL.
9 years, 2 months ago (2011-09-26 16:29:41 UTC) #1
danno
9 years, 2 months ago (2011-10-05 08:21:16 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698