Issue 8028025: Fix race in CpuProfiler::StopProcessor / CpuProfiler::TickSampleEvent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8028025: Fix race in CpuProfiler::StopProcessor / CpuProfiler::TickSampleEvent. (Closed)

Created:
9 years, 2 months ago by mnaganov (inactive)

Modified:
9 years, 2 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Fix race in CpuProfiler::StopProcessor / CpuProfiler::TickSampleEvent. R=mstarzinger@chromium.org BUG=v8:1700 TEST=inspector/profiler/cpu-profiler-profiling-without-inspector.html Committed: http://code.google.com/p/v8/source/detail?r=9433

Patch Set 1 #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/cpu-profiler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

9 years, 2 months ago (2011-09-26 16:29:12 UTC) #2

LGTM. The crasher in cpu-profiler-profiling-without-inspector.html seems to be
gone with this. Can you prefix the Bug number in the description with "v8:",
otherwise it will link to the Chromium issue tracker.

Expand Messages | Collapse Messages