Expose use-more-webui flag in chrome://flags and tweak cert viewer WebUI

Expose use-more-webui flag in chrome://flags and tweak cert viewer WebUI

We're planning on enabling some WebUI dialogs by default on ChromeOS soon, so
expose in flags to make it easier for people to test.

Also tweak the certificate viewer UI a little to make it look and behave more
like the original:
 - make it bigger (so it's generally big enough to fit the contents)
 - automatically select the main certificate in the details pane
 - scroll the details windows to the top
 - add a border around the details windows (like the original)
 - shrink hierarchy window a bit - it will rarely have more than 3 lines
 - fix spacing and indendation on the main tab

BUG=98027
TEST=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102831

[Rick Byers, 2011-09-26 16:56:38]

Hi Rob,
Can you review this for me please?

Thanks,
   Rick

[flackr, 2011-09-26 17:38:26]

Looks great. Those tweaks should really put the finishing touches on the
certificate viewer.

http://codereview.chromium.org/8028024/diff/1/chrome/app/generated_resources.grd
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/8028024/diff/1/chrome/app/generated_resources....
chrome/app/generated_resources.grd:4586: <message
name="IDS_FLAGS_USE_MORE_WEBUI_NAME" desc="Title for the flag to use more
WebUI">
nit: Punctuation.

http://codereview.chromium.org/8028024/diff/1/chrome/app/generated_resources....
chrome/app/generated_resources.grd:4589: <message
name="IDS_FLAGS_USE_MORE_WEBUI_DESCRIPTION" desc="Description for the flag to
use more WebUI">
nit: Punctuation.

http://codereview.chromium.org/8028024/diff/1/chrome/browser/resources/certif...
File chrome/browser/resources/certificate_viewer.js (right):

http://codereview.chromium.org/8028024/diff/1/chrome/browser/resources/certif...
chrome/browser/resources/certificate_viewer.js:92: last.selected = true;
You should probably change CertificateViewerUITestAsync.MAYBE_testDetails in
chrome/test/data/webui/certificate_viewer_dialog_test.js. It asserts that the
fields list starts empty, you can just remove this assert. It seems to have
passed but could definitely lead to a flaky test.

[Rick Byers, 2011-09-26 18:47:56]

Thanks Rob!

http://codereview.chromium.org/8028024/diff/1/chrome/app/generated_resources.grd
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/8028024/diff/1/chrome/app/generated_resources....
chrome/app/generated_resources.grd:4586: <message
name="IDS_FLAGS_USE_MORE_WEBUI_NAME" desc="Title for the flag to use more
WebUI">
On 2011/09/26 17:38:26, flackr wrote:
> nit: Punctuation.

Done.

http://codereview.chromium.org/8028024/diff/1/chrome/app/generated_resources....
chrome/app/generated_resources.grd:4589: <message
name="IDS_FLAGS_USE_MORE_WEBUI_DESCRIPTION" desc="Description for the flag to
use more WebUI">
On 2011/09/26 17:38:26, flackr wrote:
> nit: Punctuation.

Done.

http://codereview.chromium.org/8028024/diff/1/chrome/browser/resources/certif...
File chrome/browser/resources/certificate_viewer.js (right):

http://codereview.chromium.org/8028024/diff/1/chrome/browser/resources/certif...
chrome/browser/resources/certificate_viewer.js:92: last.selected = true;
On 2011/09/26 17:38:26, flackr wrote:
> You should probably change CertificateViewerUITestAsync.MAYBE_testDetails in
> chrome/test/data/webui/certificate_viewer_dialog_test.js. It asserts that the
> fields list starts empty, you can just remove this assert. It seems to have
> passed but could definitely lead to a flaky test.

Done.

Looks like the fact that it was passing is likely to be the test running in
between the first callback and the second.

[flackr, 2011-09-26 20:08:56]

lgtm

[commit-bot: I haz the power, 2011-09-26 22:21:54]

CQ is trying tha patch. Follow status at
https://chromium-status.appspot.com/cq/rbyers@chromium.org/8028024/6001

[commit-bot: I haz the power, 2011-09-26 23:36:12]

Change committed as 102831