Issue 8028012: More Aura fixes, renaming and stubbing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8028012: More Aura fixes, renaming and stubbing (Closed)

Created:
9 years, 3 months ago by Emmanuel Saint-loubert-Bié

Modified:
9 years, 3 months ago

Reviewers:
commit-bot: I haz the power, oshima

CC:
chromium-reviews, Evan Martin

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

+ renamed window_snapshot_x.cc => window_snapshot_gtk.cc + added window_snapshot_aura.cc + added missing members to icon_loader_aura.cc + fixed a couple of minor issues with #includes BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102659

Patch Set 1 #

Patch Set 2 : Excluding gnome keyring code. #

Patch Set 3 : Remive dup in gup. #

Patch Set 4 : Merge #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -70 lines)			Patch
M	build/common.gypi	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chrome_browser_main.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/icon_loader_aura.cc	View		1 chunk	+18 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/tabs/dragged_tab_controller.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/window_snapshot/window_snapshot_aura.cc	View		1 chunk	+19 lines, -0 lines	0 comments	Download
A +	chrome/browser/ui/window_snapshot/window_snapshot_gtk.cc	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
D	chrome/browser/ui/window_snapshot/window_snapshot_x.cc	View		1 chunk	+0 lines, -66 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Emmanuel Saint-loubert-Bié

Hi Oshima, More Aura cleanup. See description. -- Emmanuel

9 years, 3 months ago (2011-09-24 01:24:40 UTC) #1

commit-bot: I haz the power

CQ is trying tha patch. Follow status at https://chromium-status.appspot.com/cq/saintlou@chromium.org/8028012/3001

9 years, 3 months ago (2011-09-24 02:28:09 UTC) #4

commit-bot: I haz the power

9 years, 3 months ago (2011-09-24 02:51:21 UTC) #5

Try job failure for 8028012-3001 (retry) on linux_rel for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

Expand Messages | Collapse Messages