Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Unified Diff: views/widget/tooltip_manager_views.cc

Issue 8021009: Consolidate message observer API for win and aura (and touch). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: addressed msw's comments Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« views/mouse_watcher.cc ('K') | « views/widget/tooltip_manager_views.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: views/widget/tooltip_manager_views.cc
diff --git a/views/widget/tooltip_manager_views.cc b/views/widget/tooltip_manager_views.cc
index 2537d7ef98ce615cf20cfa9cee49e8469d0a8bb1..18c77a3abbe81d3b74abc5bc93b457f90de64d0c 100644
--- a/views/widget/tooltip_manager_views.cc
+++ b/views/widget/tooltip_manager_views.cc
@@ -114,23 +114,28 @@ base::MessagePumpObserver::EventStatus TooltipManagerViews::WillProcessEvent(
return base::MessagePumpObserver::EVENT_CONTINUE;
}
#elif defined(USE_X11)
-base::MessagePumpObserver::EventStatus TooltipManagerViews::WillProcessXEvent(
- XEvent* xevent) {
- XGenericEventCookie* cookie = &xevent->xcookie;
+base::EventStatus TooltipManagerViews::WillProcessEvent(
+ const base::NativeEvent& event) {
+ XGenericEventCookie* cookie = &event->xcookie;
if (cookie->evtype == XI_Motion) {
- XIDeviceEvent* xievent = static_cast<XIDeviceEvent*>(cookie->data);
+ const XIDeviceEvent* xievent = static_cast<XIDeviceEvent*>(cookie->data);
OnMouseMoved(static_cast<int>(xievent->event_x),
static_cast<int>(xievent->event_y));
}
- return base::MessagePumpObserver::EVENT_CONTINUE;
+ return base::EVENT_CONTINUE;
+}
+void TooltipManagerViews::DidProcessEvent(const base::NativeEvent& event) {
msw 2011/09/27 03:51:42 Add a blank line between these functions.
oshima 2011/09/27 16:39:39 Done.
}
+
#elif defined(OS_WIN)
-void TooltipManagerViews::WillProcessMessage(const MSG& msg) {
+base::EventStatus TooltipManagerViews::WillProcessEvent(
+ const base::NativeEvent& event) {
if (msg.message == WM_MOUSEMOVE)
OnMouseMoved(GET_X_LPARAM(msg.lParam), GET_Y_LPARAM(msg.lParam));
+ return base::EVENT_CONTINUE;
}
-void TooltipManagerViews::DidProcessMessage(const MSG& msg) {
+void TooltipManagerViews::DidProcessEvent(const base::NativeEvent& event) {
}
#endif
« views/mouse_watcher.cc ('K') | « views/widget/tooltip_manager_views.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698