Update signature for BookmarkEditor::Show for aura

Update signature for BookmarkEditor::Show for aura

BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102649

[flackr, 2011-09-23 17:57:07]

http://codereview.chromium.org/8018009/diff/1/chrome/browser/ui/views/stubs_a...
File chrome/browser/ui/views/stubs_aura.cc (right):

http://codereview.chromium.org/8018009/diff/1/chrome/browser/ui/views/stubs_a...
chrome/browser/ui/views/stubs_aura.cc:169: void
BookmarkEditor::Show(gfx::NativeWindow parent_window,
You might mean to be defining BookmarkEditor::ShowNative. BookmarkEditor::Show
is defined in chrome/browser/bookmarks/bookmark_editor.cc and delegates to
either BookmarkEditor::ShowNative or BookmarkEditor::ShowWebUI based on whether
--use-more-webui is enabled.

[oshima, 2011-09-23 18:42:04]

http://codereview.chromium.org/8018009/diff/1/chrome/browser/ui/views/stubs_a...
File chrome/browser/ui/views/stubs_aura.cc (right):

http://codereview.chromium.org/8018009/diff/1/chrome/browser/ui/views/stubs_a...
chrome/browser/ui/views/stubs_aura.cc:169: void
BookmarkEditor::Show(gfx::NativeWindow parent_window,
On 2011/09/23 17:57:07, flackr wrote:
> You might mean to be defining BookmarkEditor::ShowNative. BookmarkEditor::Show
> is defined in chrome/browser/bookmarks/bookmark_editor.cc and delegates to
> either BookmarkEditor::ShowNative or BookmarkEditor::ShowWebUI based on
whether
> --use-more-webui is enabled.

This is stubbed out for aura. Build doesn't pass to linkage , so there is a
chance that real impl of BookmarkEditor is linked and will have link error. If
that's the case, we just need to remove this. I'll put this on hold until we
know more.

[Ben Goodger (Google), 2011-09-23 20:39:20]

lgtm

[oshima, 2011-09-24 05:06:49]

This seems to be still necessary for checking in for now. I'll remove the
function if this turns out to be dup.

[commit-bot: I haz the power, 2011-09-24 05:07:09]

CQ is trying tha patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/8018009/1

[commit-bot: I haz the power, 2011-09-24 06:13:56]

Change committed as 102649