Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Side by Side Diff: src/property.h

Issue 8017003: Cache multiple ElementsKind map transition per map. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: review feedback Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/objects-printer.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
108 // MapSpace::CreateBackPointers depends on this. 108 // MapSpace::CreateBackPointers depends on this.
109 class MapTransitionDescriptor: public Descriptor { 109 class MapTransitionDescriptor: public Descriptor {
110 public: 110 public:
111 MapTransitionDescriptor(String* key, Map* map, PropertyAttributes attributes) 111 MapTransitionDescriptor(String* key, Map* map, PropertyAttributes attributes)
112 : Descriptor(key, map, attributes, MAP_TRANSITION) { } 112 : Descriptor(key, map, attributes, MAP_TRANSITION) { }
113 }; 113 };
114 114
115 class ElementsTransitionDescriptor: public Descriptor { 115 class ElementsTransitionDescriptor: public Descriptor {
116 public: 116 public:
117 ElementsTransitionDescriptor(String* key, 117 ElementsTransitionDescriptor(String* key,
118 Map* map, 118 Object* map_or_array)
119 ElementsKind elements_kind) 119 : Descriptor(key, map_or_array, PropertyDetails(NONE,
120 : Descriptor(key, map, PropertyDetails(NONE, 120 ELEMENTS_TRANSITION)) { }
121 ELEMENTS_TRANSITION,
122 elements_kind)) { }
123 }; 121 };
124 122
125 // Marks a field name in a map so that adding the field is guaranteed 123 // Marks a field name in a map so that adding the field is guaranteed
126 // to create a FIELD descriptor in the new map. Used after adding 124 // to create a FIELD descriptor in the new map. Used after adding
127 // a constant function the first time, creating a CONSTANT_FUNCTION 125 // a constant function the first time, creating a CONSTANT_FUNCTION
128 // descriptor in the new map. This avoids creating multiple maps with 126 // descriptor in the new map. This avoids creating multiple maps with
129 // the same CONSTANT_FUNCTION field. 127 // the same CONSTANT_FUNCTION field.
130 class ConstTransitionDescriptor: public Descriptor { 128 class ConstTransitionDescriptor: public Descriptor {
131 public: 129 public:
132 explicit ConstTransitionDescriptor(String* key, Map* map) 130 explicit ConstTransitionDescriptor(String* key, Map* map)
(...skipping 229 matching lines...) Expand 10 before | Expand all | Expand 10 after
362 JSReceiver* holder_; 360 JSReceiver* holder_;
363 int number_; 361 int number_;
364 bool cacheable_; 362 bool cacheable_;
365 PropertyDetails details_; 363 PropertyDetails details_;
366 }; 364 };
367 365
368 366
369 } } // namespace v8::internal 367 } } // namespace v8::internal
370 368
371 #endif // V8_PROPERTY_H_ 369 #endif // V8_PROPERTY_H_
OLDNEW
« no previous file with comments | « src/objects-printer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698