Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/gtk/download/download_item_gtk.cc

Issue 8016001: Browser crashes while closing download shelf if menu is open (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/gtk/download/download_item_gtk.cc
===================================================================
--- chrome/browser/ui/gtk/download/download_item_gtk.cc (revision 102679)
+++ chrome/browser/ui/gtk/download/download_item_gtk.cc (working copy)
@@ -266,6 +266,10 @@
}
DownloadItemGtk::~DownloadItemGtk() {
+ // First close the menu and then destroy the GtkWidgets. Bug#97724
+ if (menu_.get())
+ menu_.reset();
+
icon_consumer_.CancelAllRequests();
StopDownloadProgress();
get_download()->RemoveObserver(this);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698