Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 8016001: Browser crashes while closing download shelf if menu is open (Closed)

Created:
9 years, 3 months ago by SanjoyPal
Modified:
9 years, 1 month ago
CC:
chromium-reviews, asanka, Randy Smith (Not in Mondays)
Visibility:
Public.

Description

Browser crashes while closing download shelf if menu is open BUG=97724 TEST=1.Download a file, download shelf is shown 2.Click on the downloaded file after download completes. and quickly open the menu (the down arrow button) 3.Download shelf and menu should close itself and browser should not crash. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102682

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/ui/gtk/download/download_item_gtk.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
SanjoyPal
Please review this patch.
9 years, 3 months ago (2011-09-23 07:41:34 UTC) #1
Evan Stade
lgtm
9 years, 3 months ago (2011-09-23 19:57:54 UTC) #2
commit-bot: I haz the power
CQ is trying tha patch. Follow status at https://chromium-status.appspot.com/cq/ncj674@motorola.com/8016001/2001
9 years, 3 months ago (2011-09-23 19:58:04 UTC) #3
commit-bot: I haz the power
Presubmit check for 8016001-2001 failed and returned exit status 1. Running presubmit commit checks ...
9 years, 3 months ago (2011-09-23 19:58:07 UTC) #4
SanjoyPal
Please try again.
9 years, 3 months ago (2011-09-25 11:55:08 UTC) #5
commit-bot: I haz the power
CQ is trying tha patch. Follow status at https://chromium-status.appspot.com/cq/ncj674@motorola.com/8016001/7001
9 years, 3 months ago (2011-09-25 16:00:54 UTC) #6
commit-bot: I haz the power
Change committed as 102682
9 years, 3 months ago (2011-09-25 17:12:37 UTC) #7
SanjoyPal
9 years, 1 month ago (2011-11-10 11:50:22 UTC) #8
On 2011/09/25 17:12:37, I haz the power (commit-bot) wrote:
> Change committed as 102682

Powered by Google App Engine
This is Rietveld 408576698