Source/WebCore/bindings/v8/custom/V8HTMLAllCollectionCustom.cpp - Issue 8015008: Merge 95489 - [V8] document.all gets confused about its prototype chain

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/WebCore/bindings/v8/custom/V8HTMLAllCollectionCustom.cpp

Issue 8015008: Merge 95489 - [V8] document.all gets confused about its prototype chain (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/874/

Patch Set: Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/WebCore/bindings/v8/custom/V8DOMStringMapCustom.cpp ('k') | Source/WebCore/bindings/v8/custom/V8HTMLCollectionCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/WebCore/bindings/v8/custom/V8HTMLAllCollectionCustom.cpp

===================================================================

--- Source/WebCore/bindings/v8/custom/V8HTMLAllCollectionCustom.cpp (revision 95812)

+++ Source/WebCore/bindings/v8/custom/V8HTMLAllCollectionCustom.cpp (working copy)

@@ -74,18 +74,12 @@

v8::Handle<v8::Value> V8HTMLAllCollection::namedPropertyGetter(v8::Local<v8::String> name, const v8::AccessorInfo& info)

{

INC_STATS("DOM.HTMLAllCollection.NamedPropertyGetter");

- // Search the prototype chain first.

- v8::Handle<v8::Value> value = info.Holder()->GetRealNamedPropertyInPrototypeChain(name);

- if (!value.IsEmpty())

- return value;

- // Search local callback properties next to find IDL defined

- // properties.

+ if (!info.Holder()->GetRealNamedPropertyInPrototypeChain(name).IsEmpty())

+ return notHandledByInterceptor();

if (info.Holder()->HasRealNamedCallbackProperty(name))

- return v8::Handle<v8::Value>();

+ return notHandledByInterceptor();

- // Finally, search the DOM structure.

HTMLAllCollection* imp = V8HTMLAllCollection::toNative(info.Holder());

return getNamedItems(imp, v8StringToAtomicWebCoreString(name));

}