chrome/browser/extensions/extension_webrequest_apitest.cc - Issue 8015004: webRequest.onAuthRequired listeners can provide authentication credentials.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_webrequest_apitest.cc

Issue 8015004: webRequest.onAuthRequired listeners can provide authentication credentials. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix indent Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_webrequest_api.cc ('K') | « chrome/browser/extensions/extension_webrequest_api_constants.cc ('k') | chrome/browser/net/chrome_network_delegate.cc » ('j') | chrome/common/extensions/docs/experimental.devtools.console.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_webrequest_apitest.cc

diff --git a/chrome/browser/extensions/extension_webrequest_apitest.cc b/chrome/browser/extensions/extension_webrequest_apitest.cc

index 5ca120816be08e3914f28706405a56df42aa18d9..204468bac901bcb819cb24b0f9f5b2f69d1d20ba 100644

--- a/chrome/browser/extensions/extension_webrequest_apitest.cc

+++ b/chrome/browser/extensions/extension_webrequest_apitest.cc

@@ -69,10 +69,17 @@ IN_PROC_BROWSER_TEST_F(ExtensionWebRequestApiTest, WebRequestComplex) {

CommandLine::ForCurrentProcess()->AppendSwitch(

switches::kEnableExperimentalExtensionApis);

- // Needed for the auth tests.

+ ASSERT_TRUE(RunExtensionSubtest("webrequest", "test_complex.html")) <<

+ message_;

+IN_PROC_BROWSER_TEST_F(ExtensionWebRequestApiTest, WebRequestAuthRequired) {

+ CommandLine::ForCurrentProcess()->AppendSwitch(

+ switches::kEnableExperimentalExtensionApis);

CancelLoginDialog login_dialog_helper;

- ASSERT_TRUE(RunExtensionSubtest("webrequest", "test_complex.html")) <<

+ ASSERT_TRUE(RunExtensionSubtest("webrequest", "test_auth_required.html")) <<

message_;

}