chrome/browser/net/chrome_network_delegate.cc - Issue 8015004: webRequest.onAuthRequired listeners can provide authentication credentials.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/net/chrome_network_delegate.cc

Issue 8015004: webRequest.onAuthRequired listeners can provide authentication credentials. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Handle multiple blocking onAuthRequired Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_webrequest_api_constants.h ('K') | « chrome/browser/net/chrome_network_delegate.h ('k') | chrome/common/extensions/api/extension_api.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/net/chrome_network_delegate.cc

diff --git a/chrome/browser/net/chrome_network_delegate.cc b/chrome/browser/net/chrome_network_delegate.cc

index 681799ad1a8ed6c01ebce780dce81b1f38c77836..f3d5e41c2dd958c02d6d15489db091b5b0382ed2 100644

--- a/chrome/browser/net/chrome_network_delegate.cc

+++ b/chrome/browser/net/chrome_network_delegate.cc

@@ -160,9 +160,12 @@ void ChromeNetworkDelegate::OnPACScriptError(int line_number,

event_router_.get(), profile_, line_number, error);

}

-void ChromeNetworkDelegate::OnAuthRequired(

+int ChromeNetworkDelegate::OnAuthRequired(

net::URLRequest* request,

- const net::AuthChallengeInfo& auth_info) {

- ExtensionWebRequestEventRouter::GetInstance()->OnAuthRequired(

- profile_, extension_info_map_.get(), request, auth_info);

+ const net::AuthChallengeInfo& auth_info,

+ net::CompletionCallback* callback,

+ net::AuthCredentials* credentials) {

+ return ExtensionWebRequestEventRouter::GetInstance()->OnAuthRequired(

+ profile_, extension_info_map_.get(), request, auth_info,

+ callback, credentials);

}