Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: chrome/browser/ui/gtk/bubble/bubble_gtk.cc

Issue 8015002: Browser crash when pressing Ctrl+D Ctrl+W (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/gtk/bubble/bubble_gtk.cc
===================================================================
--- chrome/browser/ui/gtk/bubble/bubble_gtk.cc (revision 102449)
+++ chrome/browser/ui/gtk/bubble/bubble_gtk.cc (working copy)
@@ -399,7 +399,7 @@
GdkEventKey msg;
GdkKeymapKey* keys;
gint n_keys;
-
+ bool close_bubble = false;
switch (keyval) {
case GDK_Escape:
// Close on Esc and trap the accelerator
@@ -409,7 +409,7 @@
case GDK_w:
// Close on C-w and forward the accelerator
if (modifier & GDK_CONTROL_MASK) {
- Close();
+ close_bubble = true;
}
break;
default:
@@ -446,6 +446,8 @@
// of something off if it happens regularly.
DLOG(WARNING) << "Found no keys for value " << keyval;
}
+ if (close_bubble == true)
Evan Stade 2011/09/23 20:09:42 no == true
+ Close();
return TRUE;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698