Browser crash when pressing Ctrl+D Ctrl+W

Browser crash when pressing Ctrl+D Ctrl+W

BUG=78240
TEST=Launch browser and press Ctrl+D to bookmark the page, bookmark bubble is shown. Now, press Ctrl+W to close the tab while bookmark buuble is there.
Browser should close the bookmark bubble and the tab properly.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=103019

[SanjoyPal, 2011-09-23 12:08:58]

please review the changes.

[Evan Stade, 2011-09-23 20:09:42]

http://codereview.chromium.org/8015002/diff/1/chrome/browser/ui/gtk/bubble/bu...
File chrome/browser/ui/gtk/bubble/bubble_gtk.cc (right):

http://codereview.chromium.org/8015002/diff/1/chrome/browser/ui/gtk/bubble/bu...
chrome/browser/ui/gtk/bubble/bubble_gtk.cc:419:
gdk_keymap_get_entries_for_keyval(NULL,
can you just move this entire block into the GDK_w case? Otherwise it's not
obvious that it's only here for that exact case and that any other keypress
would have returned by now.

http://codereview.chromium.org/8015002/diff/1/chrome/browser/ui/gtk/bubble/bu...
chrome/browser/ui/gtk/bubble/bubble_gtk.cc:449: if (close_bubble == true)
no == true

[SanjoyPal, 2011-09-25 12:06:30]

On 2011/09/23 20:09:42, Evan Stade wrote:
>
http://codereview.chromium.org/8015002/diff/1/chrome/browser/ui/gtk/bubble/bu...
> File chrome/browser/ui/gtk/bubble/bubble_gtk.cc (right):
> 
>
http://codereview.chromium.org/8015002/diff/1/chrome/browser/ui/gtk/bubble/bu...
> chrome/browser/ui/gtk/bubble/bubble_gtk.cc:419:
> gdk_keymap_get_entries_for_keyval(NULL,
> can you just move this entire block into the GDK_w case? Otherwise it's not
> obvious that it's only here for that exact case and that any other keypress
> would have returned by now.

Done.
> 
>
http://codereview.chromium.org/8015002/diff/1/chrome/browser/ui/gtk/bubble/bu...
> chrome/browser/ui/gtk/bubble/bubble_gtk.cc:449: if (close_bubble == true)
> no == true

Please review once.

[Evan Stade, 2011-09-27 00:48:54]

lgtm

[Evan Stade, 2011-09-27 01:00:25]

(I'm sending all your CLs by the trybots)

[commit-bot: I haz the power, 2011-09-27 20:21:16]

CQ is trying tha patch. Follow status at
https://chromium-status.appspot.com/cq/ncj674@motorola.com/8015002/3001

[commit-bot: I haz the power, 2011-09-27 21:55:30]

Change committed as 103019

[SanjoyPal, 2011-11-10 11:50:51]

On 2011/09/27 21:55:30, I haz the power (commit-bot) wrote:
> Change committed as 103019