Remove the \servers build output directory and place Chrome Frame parts into the root output fold...

Remove the \servers build output directory and place Chrome Frame parts into the root output folder next to chrome.exe et al.

Also add a more helpful error message when failing to register the Chrome Frame dll.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102780

[grt (UTC plus 2), 2011-09-23 13:40:04]

sweet, man.  i think the bike in this case is quite small, so painting the shed
should be pretty quick.

http://codereview.chromium.org/8013001/diff/1/chrome_frame/chrome_launcher_ut...
File chrome_frame/chrome_launcher_utils.cc (right):

http://codereview.chromium.org/8013001/diff/1/chrome_frame/chrome_launcher_ut...
chrome_frame/chrome_launcher_utils.cc:22: CommandLine*
CreateChromeLauncherCommandLine() {
boy do i wish this was:
void CreateChromeLauncherCommandLine(scoped_ptr<CommandLine>* command_line)
but i'm not going to make you do that

http://codereview.chromium.org/8013001/diff/1/chrome_frame/chrome_launcher_ut...
chrome_frame/chrome_launcher_utils.cc:26: // existence of the file and try the
path that includes the /servers/
please update comment

http://codereview.chromium.org/8013001/diff/1/chrome_frame/chrome_launcher_ut...
chrome_frame/chrome_launcher_utils.cc:40: return NULL;
this NULL will call callers to explode in release mode since the contract for
this and CreateLaunchCommandLine doesn't indicate that NULL is a valid response.
 would you mind refactoring this and the related functions and their callers so
that this doesn't happen?  i'll do (more) cartwheels down the hall if you take
my scoped_ptr suggestion into account, too.

[robertshield, 2011-09-23 20:31:13]

http://codereview.chromium.org/8013001/diff/1/chrome_frame/chrome_launcher_ut...
File chrome_frame/chrome_launcher_utils.cc (right):

http://codereview.chromium.org/8013001/diff/1/chrome_frame/chrome_launcher_ut...
chrome_frame/chrome_launcher_utils.cc:22: CommandLine*
CreateChromeLauncherCommandLine() {
On 2011/09/23 13:40:05, grt wrote:
> boy do i wish this was:
> void CreateChromeLauncherCommandLine(scoped_ptr<CommandLine>* command_line)
> but i'm not going to make you do that

Yes, yes you are.

http://codereview.chromium.org/8013001/diff/1/chrome_frame/chrome_launcher_ut...
chrome_frame/chrome_launcher_utils.cc:26: // existence of the file and try the
path that includes the /servers/
On 2011/09/23 13:40:05, grt wrote:
> please update comment

Done.

http://codereview.chromium.org/8013001/diff/1/chrome_frame/chrome_launcher_ut...
chrome_frame/chrome_launcher_utils.cc:40: return NULL;
On 2011/09/23 13:40:05, grt wrote:
> this NULL will call callers to explode in release mode since the contract for
> this and CreateLaunchCommandLine doesn't indicate that NULL is a valid
response.
>  would you mind refactoring this and the related functions and their callers
so
> that this doesn't happen?  i'll do (more) cartwheels down the hall if you take
> my scoped_ptr suggestion into account, too.

Very well, I expect better cartwheels though.

[grt (UTC plus 2), 2011-09-23 21:18:11]

LGTM with a tiny nit.

cartwheels on monday.

http://codereview.chromium.org/8013001/diff/7001/chrome_frame/chrome_launcher...
File chrome_frame/chrome_launcher_utils.cc (right):

http://codereview.chromium.org/8013001/diff/7001/chrome_frame/chrome_launcher...
chrome_frame/chrome_launcher_utils.cc:58: scoped_ptr<CommandLine>
chrome_launcher_cmd;
i don't see a problem with using |command_line| rather than making a new one. 
are you doing this to be defensive in some way?

[robertshield, 2011-09-26 16:35:24]

http://codereview.chromium.org/8013001/diff/7001/chrome_frame/chrome_launcher...
File chrome_frame/chrome_launcher_utils.cc (right):

http://codereview.chromium.org/8013001/diff/7001/chrome_frame/chrome_launcher...
chrome_frame/chrome_launcher_utils.cc:58: scoped_ptr<CommandLine>
chrome_launcher_cmd;
On 2011/09/23 21:18:11, grt wrote:
> i don't see a problem with using |command_line| rather than making a new one. 
> are you doing this to be defensive in some way?

Not meaningfully, removed.