Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Unified Diff: chrome/browser/ui/cocoa/download/download_shelf_controller.mm

Issue 8008021: Add new UMA stats to get a handle on Downloads UI Usage (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: merge Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/history/history_unittest.cc ('k') | chrome/browser/ui/gtk/download/download_shelf_gtk.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/download/download_shelf_controller.mm
diff --git a/chrome/browser/ui/cocoa/download/download_shelf_controller.mm b/chrome/browser/ui/cocoa/download/download_shelf_controller.mm
index fb69b913340d9eaddedf312fc7cb97566db84aa4..037e0225e35feb7e5ae583b029d71c4a441d8f07 100644
--- a/chrome/browser/ui/cocoa/download/download_shelf_controller.mm
+++ b/chrome/browser/ui/cocoa/download/download_shelf_controller.mm
@@ -20,6 +20,7 @@
#import "chrome/browser/ui/cocoa/presentation_mode_controller.h"
#include "content/browser/download/download_item.h"
#include "content/browser/download/download_manager.h"
+#include "content/browser/download/download_stats.h"
#import "third_party/GTM/AppKit/GTMNSAnimation+Duration.h"
#include "ui/base/l10n/l10n_util.h"
@@ -243,10 +244,19 @@ const NSSize kHoverCloseButtonDefaultSize = { 16, 16 };
// If |sender| isn't nil, then we're being closed from the UI by the user and
// we need to tell our shelf implementation to close. Otherwise, we're being
// closed programmatically by our shelf implementation.
- if (sender)
- bridge_->Close();
- else
+ bool auto_closed = (sender == nil);
+
+ int numInProgress = 0;
+ for (NSUInteger i = 0; i < [downloadItemControllers_ count]; ++i) {
+ if ([[downloadItemControllers_ objectAtIndex:i]download]->IsInProgress())
+ ++numInProgress;
+ }
+ download_stats::RecordShelfClose(
+ [downloadItemControllers_ count], numInProgress, auto_closed);
+ if (auto_closed)
[self showDownloadShelf:NO];
+ else
+ bridge_->Close();
}
- (void)animationDidEnd:(NSAnimation*)animation {
« no previous file with comments | « chrome/browser/history/history_unittest.cc ('k') | chrome/browser/ui/gtk/download/download_shelf_gtk.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698