chrome/browser/web_resource/promo_resource_service.cc - Issue 8008021: Add new UMA stats to get a handle on Downloads UI Usage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/web_resource/promo_resource_service.cc

Issue 8008021: Add new UMA stats to get a handle on Downloads UI Usage (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: comments Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/web_resource/promo_resource_service.cc

diff --git a/chrome/browser/web_resource/promo_resource_service.cc b/chrome/browser/web_resource/promo_resource_service.cc

index 7b62757bbe66abedf4c8fceb3165a2f622d7826e..5ee1cff4d476e6442570d53d06e694b1f167be54 100644

--- a/chrome/browser/web_resource/promo_resource_service.cc

+++ b/chrome/browser/web_resource/promo_resource_service.cc

@@ -296,7 +296,8 @@ void PromoResourceService::SetNotificationParams(DictionaryValue* a_dic) {

max_group < 0 ||

max_group >= kNTPPromoGroupSize) {

// If values are not valid, do not show promo.

- NOTREACHED() << "Invalid server data, question=" << question <<

+ LOG(ERROR) << "Invalid server data, question=" << question <<

+ ", err=" << err <<

", build=" << promo_build <<

", time_slice=" << time_slice <<

", max_group=" << max_group;