Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5452)

Unified Diff: chrome/browser/history/download_database.h

Issue 8008021: Add new UMA stats to get a handle on Downloads UI Usage (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: comments Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/history/download_database.h
diff --git a/chrome/browser/history/download_database.h b/chrome/browser/history/download_database.h
index 1d5d3fde9de3c1d361aeb0e86b45b3d12061ab2f..90e29307ee46e17685a29a4cd680048eb7f1f0be 100644
--- a/chrome/browser/history/download_database.h
+++ b/chrome/browser/history/download_database.h
@@ -7,6 +7,7 @@
#pragma once
#include <set>
+#include <string>
#include "base/threading/platform_thread.h"
#include "chrome/browser/history/history_types.h"
@@ -34,7 +35,8 @@ class DownloadDatabase {
void QueryDownloads(std::vector<DownloadPersistentStoreInfo>* results);
// Update the state of one download. Returns true if successful.
- bool UpdateDownload(int64 received_bytes, int32 state, DownloadID db_handle);
+ // Does not update |url|, |start_time|, |total_bytes|, or |db_handle|.
Randy Smith (Not in Mondays) 2011/10/04 18:34:31 The comment that it doesn't update db_handle is a
benjhayden 2011/10/06 21:25:16 Done.
+ bool UpdateDownload(const DownloadPersistentStoreInfo& data);
// Update the path of one download. Returns true if successful.
bool UpdateDownloadPath(const FilePath& path, DownloadID db_handle);
@@ -69,6 +71,8 @@ class DownloadDatabase {
bool DropDownloadTable();
private:
+ bool EnsureColumnExists(const std::string& name, const std::string& type);
+
// TODO(rdsmith): Remove after http://crbug.com/96627 has been resolved.
std::set<int64> returned_ids_;
bool owning_thread_set_;

Powered by Google App Engine
This is Rietveld 408576698