Add new UMA stats to get a handle on Downloads UI Usage

chrome/browser/history/history_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // History unit tests come in two flavors:
 //
 // 1. The more complicated style is that the unit test creates a full history
 //    service. This spawns a background thread for the history backend, and
 //    all communication is asynchronous. This is useful for testing more
 //    complicated things or end-to-end behavior.
@@ skipping 175 matching lines @@
     // our destroy task.
     MessageLoop::current()->Run();
   }
 
   int64 AddDownload(int32 state, const Time& time) {
     DownloadPersistentStoreInfo download(
         FilePath(FILE_PATH_LITERAL("foo-path")),
         GURL("foo-url"),
         GURL(""),
         time,
+        time,
         0,
         512,
         state,
+        0,
         0);
     return db_->CreateDownload(download);
   }
 
   // Fills the query_url_row_ and query_url_visits_ structures with the
   // information about the given URL and returns true. If the URL was not
   // found, this will return false and those structures will not be changed.
   bool QueryURL(HistoryService* history, const GURL& url) {
     history->QueryURL(url, true, &consumer_,
                       base::Bind(&HistoryTest::SaveURLAndQuit,
@@ skipping 152 matching lines @@
   EXPECT_EQ(DownloadItem::COMPLETE, downloads[0].state);
   EXPECT_EQ(0, downloads[0].start_time.ToInternalValue());
   EXPECT_EQ(DownloadItem::IN_PROGRESS, downloads[1].state);
   EXPECT_EQ(month_ago_lossy.ToInternalValue(),
             downloads[1].start_time.ToInternalValue());
   EXPECT_EQ(DownloadItem::REMOVING, downloads[2].state);
   EXPECT_EQ(month_ago_lossy.ToInternalValue(),
             downloads[2].start_time.ToInternalValue());
 
   // Change state so we can delete the downloads.
-  EXPECT_TRUE(db_->UpdateDownload(512, DownloadItem::COMPLETE, in_progress));
-  EXPECT_TRUE(db_->UpdateDownload(512, DownloadItem::CANCELLED, removing));
+  DownloadPersistentStoreInfo data;
+  data.received_bytes = 512;
+  data.state = DownloadItem::COMPLETE;
+  data.end_time = base::Time::Now();
+  data.opened = false;
+  data.db_handle = in_progress;
+  EXPECT_TRUE(db_->UpdateDownload(data));
+  data.state = DownloadItem::CANCELLED;
+  data.db_handle = removing;
+  EXPECT_TRUE(db_->UpdateDownload(data));
 
   // Try removing from Time=0. This should delete all.
   db_->RemoveDownloadsBetween(Time(), Time());
   db_->QueryDownloads(&downloads);
   EXPECT_EQ(0U, downloads.size());
 
   // Check removal of downloads stuck in IN_PROGRESS state.
   EXPECT_NE(0, AddDownload(DownloadItem::COMPLETE,    month_ago));
   EXPECT_NE(0, AddDownload(DownloadItem::IN_PROGRESS, month_ago));
   db_->QueryDownloads(&downloads);
@@ skipping 479 matching lines @@
   history_service_ = history;
   history->ScheduleDBTask(task.get(), &request_consumer);
   request_consumer.CancelAllRequests();
   CleanupHistoryService();
   // WARNING: history has now been deleted.
   history = NULL;
   ASSERT_FALSE(task->done_invoked);
 }
 
 }  // namespace history