Add new UMA stats to get a handle on Downloads UI Usage

chrome/browser/ui/views/download/download_shelf_view.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/download/download_shelf_view.h"
 
 #include <algorithm>
 
 #include "base/logging.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/download/download_item_model.h"
 #include "chrome/browser/themes/theme_service.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/view_ids.h"
 #include "chrome/browser/ui/views/download/download_item_view.h"
 #include "chrome/browser/ui/views/frame/browser_view.h"
 #include "content/browser/download/download_item.h"
+#include "content/browser/download/download_stats.h"
 #include "content/browser/download/download_manager.h"
 #include "content/browser/tab_contents/navigation_entry.h"
 #include "grit/generated_resources.h"
 #include "grit/theme_resources.h"
 #include "grit/theme_resources_standard.h"
 #include "ui/base/animation/slide_animation.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/gfx/canvas.h"
 #include "views/background.h"
@@ skipping 52 matching lines @@
 
 int CenterPosition(int size, int target_size) {
   return std::max((target_size - size) / 2, kTopBottomPadding);
 }
 
 }  // namespace
 
 DownloadShelfView::DownloadShelfView(Browser* browser, BrowserView* parent)
     : browser_(browser),
       parent_(parent),
+      auto_closed_(false),
       ALLOW_THIS_IN_INITIALIZER_LIST(
           mouse_watcher_(this, this, gfx::Insets())) {
   mouse_watcher_.set_notify_on_exit_time_ms(kNotifyOnExitTimeMS);
   set_id(VIEW_ID_DOWNLOAD_SHELF);
   parent->AddChildView(this);
   Init();
 }
 
 DownloadShelfView::~DownloadShelfView() {
   parent_->RemoveChildView(this);
@@ skipping 45 matching lines @@
   new_item_animation_->Show();
 }
 
 void DownloadShelfView::AddDownload(BaseDownloadItemModel* download_model) {
   DownloadItemView* view = new DownloadItemView(
       download_model->download(), this, download_model);
   AddDownloadView(view);
 }
 
 void DownloadShelfView::MouseMovedOutOfView() {
+  auto_closed_ = true;

[Randy Smith (Not in Mondays), 2011/10/04 18:34:31]

This seems weird to me.  Are you sure?  Two concerns:
+ I thought that the Windows shelf closed on last unopened download open; this
function doesn't sound like it's used in that case.
+ If a shelf can close and reopen, that doesn't reset auto_closed_ to false.

[benjhayden, 2011/10/06 21:25:16]

Done.

   Close();
 }
 
 void DownloadShelfView::FocusWillChange(views::View* focused_before,
                                         views::View* focused_now) {
   SchedulePaintForDownloadItem(focused_before);
   SchedulePaintForDownloadItem(focused_now);
   AccessiblePaneView::FocusWillChange(focused_before, focused_now);
 }
 
@@ skipping 211 matching lines @@
 
 bool DownloadShelfView::IsClosing() const {
   return shelf_animation_->IsClosing();
 }
 
 void DownloadShelfView::Show() {
   shelf_animation_->Show();
 }
 
 void DownloadShelfView::Close() {
+  int num_pending = 0;
+  for (size_t i = 0; i < download_views_.size(); ++i) {
+    if (download_views_[i]->download()->IsInProgress())
+      ++num_pending;
+  }
+  download_stats::RecordShelfClose(
+      download_views_.size(), num_pending, auto_closed_);
   parent_->SetDownloadShelfVisible(false);
   shelf_animation_->Hide();
 }
 
 Browser* DownloadShelfView::browser() const {
   return browser_;
 }
 
 void DownloadShelfView::Closed() {
   // When the close animation is complete, remove all completed downloads.
@@ skipping 47 matching lines @@
     const DownloadItemView* download_item_view) {
   gfx::Rect bounds = download_item_view->bounds();
 
 #if defined(TOOLKIT_VIEWS)
   bounds.set_height(bounds.height() - 1);
   bounds.Offset(0, 3);
 #endif
 
   return bounds;
 }