Add new UMA stats to get a handle on Downloads UI Usage

content/browser/download/download_persistent_store_info.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Download struct used for informing and querying the download system's
 // persitent store.
 
 #ifndef CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_PERSISTENT_STORE_INFO_H_
 #define CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_PERSISTENT_STORE_INFO_H_
 #pragma once
 
 #include <vector>
 
 #include "base/file_path.h"
 #include "base/time.h"
 #include "content/common/content_export.h"
 #include "googleurl/src/gurl.h"
 
 class DownloadItem;
 
 // Contains the information that is stored in the download system's persistent
 // store (or refers to it).  Managed by the DownloadItem.
 struct CONTENT_EXPORT DownloadPersistentStoreInfo {
   // TODO(ahendrickson) -- Reduce the number of constructors.

[Randy Smith (Not in Mondays), 2011/09/30 15:57:21]

I think it's reasonable to remove this--at least, a default constructor and a
full list constructor seem reasonable to me.  Could you check with Andy and then
maybe nuke this line while you're here?

[benjhayden, 2011/10/03 20:54:39]

Andy still wants to fix it.

   DownloadPersistentStoreInfo();
   DownloadPersistentStoreInfo(const FilePath& path,
                               const GURL& url,
                               const GURL& referrer,
                               const base::Time& start,
+                              const base::Time& end,
                               int64 received,
                               int64 total,
                               int32 download_state,
-                              int64 handle);
+                              int64 handle,
+                              bool opend);

[Randy Smith (Not in Mondays), 2011/09/30 15:57:21]

nit: I dislike deliberately misspelling something to get around namespace
collisions.  download_opened?  been_opened?

[benjhayden, 2011/10/03 20:54:39]

Done.

   ~DownloadPersistentStoreInfo();  // For linux-clang.
 
   // The final path where the download is saved.
   FilePath path;
 
   // The URL from which we are downloading. This is the final URL after any
   // redirection by the server for |url_chain|.
   GURL url;
 
   // The URL that referred us.
   GURL referrer_url;
 
   // The time when the download started.
   base::Time start_time;
 
+  // The time when the download completed.
+  base::Time end_time;
+
   // The number of bytes received (so far).
   int64 received_bytes;
 
   // The total number of bytes in the download.
   int64 total_bytes;
 
   // The current state of the download.
   int32 state;
 
   // The handle of the download in the database.
   int64 db_handle;
+
+  bool opened;

[Randy Smith (Not in Mondays), 2011/09/30 15:57:21]

It's pretty obvious, but I'd still include a comment here about what this
variable means.

[benjhayden, 2011/10/03 20:54:39]

Done.

 };
 
 #endif  // CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_PERSISTENT_STORE_INFO_H_