Add new UMA stats to get a handle on Downloads UI Usage

chrome/browser/ui/views/download/download_shelf_view.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/download/download_shelf_view.h"
 
 #include <algorithm>
 
 #include "base/logging.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/download/download_item_model.h"
 #include "chrome/browser/themes/theme_service.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/view_ids.h"
 #include "chrome/browser/ui/views/download/download_item_view.h"
 #include "chrome/browser/ui/views/frame/browser_view.h"
 #include "content/browser/download/download_item.h"
+#include "content/browser/download/download_stats.h"
 #include "content/browser/download/download_manager.h"
 #include "content/browser/tab_contents/navigation_entry.h"
 #include "grit/generated_resources.h"
 #include "grit/theme_resources.h"
 #include "grit/theme_resources_standard.h"
 #include "ui/base/animation/slide_animation.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/gfx/canvas.h"
 #include "views/background.h"
@@ skipping 348 matching lines @@
 
 bool DownloadShelfView::IsClosing() const {
   return shelf_animation_->IsClosing();
 }
 
 void DownloadShelfView::Show() {
   shelf_animation_->Show();
 }
 
 void DownloadShelfView::Close() {
+  download_stats::RecordShelfSize(download_views_.size());
+  int num_pending = 0;
+  for (size_t i = 0; i < download_views_.size(); ++i) {
+    DownloadItem* download = download_views_[i]->download();
+    bool is_transfer_done = download->IsComplete() ||

[brettw, 2011/10/01 16:45:45]

This code is duplicated a number of times. Should we consider adding
is_transfer_done() to DownloadItem as a helper? Then this whole loop can be
  if (download_views_[i]->download()->is_transfer_done())
    ++num_pending;

[benjhayden, 2011/10/03 20:54:39]

Done with IsInProgress().

+                            download->IsCancelled() ||
+                            download->IsInterrupted();
+    if (!is_transfer_done)
+      ++num_pending;
+  }
+  download_stats::RecordShelfPendingSize(num_pending);
   parent_->SetDownloadShelfVisible(false);
   shelf_animation_->Hide();
 }
 
 Browser* DownloadShelfView::browser() const {
   return browser_;
 }
 
 void DownloadShelfView::Closed() {
   // When the close animation is complete, remove all completed downloads.
@@ skipping 47 matching lines @@
     const DownloadItemView* download_item_view) {
   gfx::Rect bounds = download_item_view->bounds();
 
 #if defined(TOOLKIT_VIEWS)
   bounds.set_height(bounds.height() - 1);
   bounds.Offset(0, 3);
 #endif
 
   return bounds;
 }