Issue 8008016: Small refactor to KeyedStoreIC::GenerateGeneric to make it slightly faster.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8008016: Small refactor to KeyedStoreIC::GenerateGeneric to make it slightly faster. (Closed)

Created:
9 years, 3 months ago by Yang

Modified:
9 years, 2 months ago

Reviewers:
Rico

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Small refactor to KeyedStoreIC::GenerateGeneric to make it slightly faster. Committed: http://code.google.com/p/v8/source/detail?r=9418

Patch Set 1 #

Total comments: 3

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -27 lines)			Patch
	M	src/arm/ic-arm.cc	View		2 chunks	+13 lines, -16 lines	2 comments	Download
	M	src/ia32/ic-ia32.cc	View		1 chunk	+11 lines, -11 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Yang

Please take a look. Checking for smi before checking for non-smi array should make storing ...

9 years, 3 months ago (2011-09-23 14:45:45 UTC) #1

Rico

9 years, 3 months ago (2011-09-24 18:40:35 UTC) #2

LGTM

http://codereview.chromium.org/8008016/diff/1/src/arm/ic-arm.cc
File src/arm/ic-arm.cc (right):

http://codereview.chromium.org/8008016/diff/1/src/arm/ic-arm.cc#newcode1367
src/arm/ic-arm.cc:1367: __ add(address, elements,
fits on one line

http://codereview.chromium.org/8008016/diff/1/src/arm/ic-arm.cc#newcode1375
src/arm/ic-arm.cc:1375: // Make sure the elements are smi-only.
Comment seems wrong now, that is not what we check anymore.
Probably something like:
// If this is a smi only array call runtime.
(or be more generic if you like, this might not be Danno's last array type
specialization :-) )

http://codereview.chromium.org/8008016/diff/1/src/ia32/ic-ia32.cc
File src/ia32/ic-ia32.cc (right):

http://codereview.chromium.org/8008016/diff/1/src/ia32/ic-ia32.cc#newcode821
src/ia32/ic-ia32.cc:821: if (FLAG_smi_only_arrays) {
Move (corrected) comment from ic-arm.cc in here

Expand Messages | Collapse Messages