Issue 8008005: [ntp4] Create app tiles using template data.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8008005: [ntp4] Create app tiles using template data. (Closed)

Created:
9 years, 3 months ago by csilv

Modified:
9 years, 3 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews, estade+watch_chromium.org, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

[ntp4] Create app tiles using template data. When creating app tiles, use HTML template data rather than constructing the hiearchy in javascript. Also move style data to the CSS file. This should improve flexibility for making future changes. BUG=none TEST=Verify that app tiles continue to look and behave the same. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102398

Patch Set 1 #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+50 lines, -38 lines)			Patch
M	chrome/browser/resources/ntp4/apps_page.css	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/ntp4/apps_page.js	View	3 chunks	+25 lines, -38 lines	0 comments	Download
M	chrome/browser/resources/ntp4/new_tab.html	View	1 chunk	+19 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

I dig it. LGTM

Expand Messages | Collapse Messages