Issue 8008003: wstring: remove SplitStringAlongWhitespace for wchar

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8008003: wstring: remove SplitStringAlongWhitespace for wchar (Closed)

Created:
9 years, 3 months ago by Evan Martin

Modified:
9 years, 3 months ago

Reviewers:
Elliot Glaysher

CC:
chromium-reviews, Paweł Hajdan Jr., jshin+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

wstring: remove SplitStringAlongWhitespace for wchar There was only one user, which did a bunch of nonsense. BUG=23581 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102563

Patch Set 1 #

Patch Set 2 : ok #

Patch Set 3 : ok #

Patch Set 4 : fix test #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -38 lines)			Patch
M	base/string_split.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	base/string_split.cc	View		1 chunk	+0 lines, -7 lines	0 comments	Download
M	base/string_split_unittest.cc	View	1 2 3	1 chunk	+17 lines, -17 lines	0 comments	Download
M	chrome/browser/themes/theme_service.cc	View	1	1 chunk	+8 lines, -12 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

sending it to you due to the theme code, please check carefully

9 years, 3 months ago (2011-09-22 22:26:06 UTC) #1

Elliot Glaysher

9 years, 3 months ago (2011-09-23 17:38:47 UTC) #3

lgtm; this code always expects ascii anyway.

On Fri, Sep 23, 2011 at 10:14 AM,  <evan@chromium.org> wrote:
> ping
>
> http://codereview.chromium.org/8008003/
>

Expand Messages | Collapse Messages