Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3726)

Unified Diff: chrome/browser/safe_browsing/prefix_set.cc

Issue 8005001: Reserve space before building potentially large vectors in safe-browsing. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/prefix_set.cc
diff --git a/chrome/browser/safe_browsing/prefix_set.cc b/chrome/browser/safe_browsing/prefix_set.cc
index 9d568cbbc64afaabdde2d40f2949095e76f0bf10..d9a889745c43a2c82bf4a27daaf7b3c75aa89072 100644
--- a/chrome/browser/safe_browsing/prefix_set.cc
+++ b/chrome/browser/safe_browsing/prefix_set.cc
@@ -42,6 +42,13 @@ namespace safe_browsing {
PrefixSet::PrefixSet(const std::vector<SBPrefix>& sorted_prefixes)
: checksum_(0) {
if (sorted_prefixes.size()) {
+ // Estimate the resulting vector sizes. There will be strictly
+ // more than |min_runs| entries in |index_|, but there generally
+ // aren't many forced breaks.
+ const size_t min_runs = sorted_prefixes.size() / kMaxRun;
+ index_.reserve(min_runs);
+ deltas_.reserve(sorted_prefixes.size() - min_runs);
+
// Lead with the first prefix.
SBPrefix prev_prefix = sorted_prefixes[0];
size_t run_length = 0;
@@ -141,6 +148,8 @@ bool PrefixSet::Exists(SBPrefix prefix) const {
}
void PrefixSet::GetPrefixes(std::vector<SBPrefix>* prefixes) const {
+ prefixes->reserve(index_.size() + deltas_.size());
+
for (size_t ii = 0; ii < index_.size(); ++ii) {
// The deltas for this |index_| entry run to the next index entry,
// or the end of the deltas.

Powered by Google App Engine
This is Rietveld 408576698