New and updated documentation.

New and updated documentation.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106973

[alokp, 2011-09-27 15:48:30]

Overall looks great I have some minor comments.

Are you anyway working on an old version of the file. For example I did not see
GetError() function defined.

http://codereview.chromium.org/8004005/diff/1/ppapi/cpp/graphics_3d.h
File ppapi/cpp/graphics_3d.h (right):

http://codereview.chromium.org/8004005/diff/1/ppapi/cpp/graphics_3d.h#newcode37
ppapi/cpp/graphics_3d.h:37: /// in <code>attrib_list</code>, then the default
value of 0 is used.
Not all default vales are 0.

http://codereview.chromium.org/8004005/diff/1/ppapi/cpp/graphics_3d.h#newcode125
ppapi/cpp/graphics_3d.h:125: /// This example retrieves the values for rgb bits
in the color buffer.
Should this line be moved before the example?

http://codereview.chromium.org/8004005/diff/1/ppapi/cpp/graphics_3d.h#newcode143
ppapi/cpp/graphics_3d.h:143: /// @param[in] width The width.
The width of backing surface?

[jond, 2011-10-11 15:46:46]

GetError() only seems to appear in the C files, not in the C++ files. Do we have
IDL for the C files yet?

On 2011/09/27 15:48:30, Alok Priyadarshi wrote:
> Overall looks great I have some minor comments.
> 
> Are you anyway working on an old version of the file. For example I did not
see
> GetError() function defined.
> 
> http://codereview.chromium.org/8004005/diff/1/ppapi/cpp/graphics_3d.h
> File ppapi/cpp/graphics_3d.h (right):
> 
>
http://codereview.chromium.org/8004005/diff/1/ppapi/cpp/graphics_3d.h#newcode37
> ppapi/cpp/graphics_3d.h:37: /// in <code>attrib_list</code>, then the default
> value of 0 is used.
> Not all default vales are 0.
> 
>
http://codereview.chromium.org/8004005/diff/1/ppapi/cpp/graphics_3d.h#newcode125
> ppapi/cpp/graphics_3d.h:125: /// This example retrieves the values for rgb
bits
> in the color buffer.
> Should this line be moved before the example?
> 
>
http://codereview.chromium.org/8004005/diff/1/ppapi/cpp/graphics_3d.h#newcode143
> ppapi/cpp/graphics_3d.h:143: /// @param[in] width The width.
> The width of backing surface?

[jond, 2011-10-11 15:46:51]

http://codereview.chromium.org/8004005/diff/1/ppapi/cpp/graphics_3d.h
File ppapi/cpp/graphics_3d.h (right):

http://codereview.chromium.org/8004005/diff/1/ppapi/cpp/graphics_3d.h#newcode37
ppapi/cpp/graphics_3d.h:37: /// in <code>attrib_list</code>, then the default
value of 0 is used.
On 2011/09/27 15:48:30, Alok Priyadarshi wrote:
> Not all default vales are 0.

Please clarify. All seemed to have Default: 0 in the original file.

http://codereview.chromium.org/8004005/diff/1/ppapi/cpp/graphics_3d.h#newcode125
ppapi/cpp/graphics_3d.h:125: /// This example retrieves the values for rgb bits
in the color buffer.
On 2011/09/27 15:48:30, Alok Priyadarshi wrote:
> Should this line be moved before the example?

Its okay to introduce the example and then discuss after.

http://codereview.chromium.org/8004005/diff/1/ppapi/cpp/graphics_3d.h#newcode143
ppapi/cpp/graphics_3d.h:143: /// @param[in] width The width.
On 2011/09/27 15:48:30, Alok Priyadarshi wrote:
> The width of backing surface?

Done.

[alokp, 2011-10-17 16:30:32]

http://codereview.chromium.org/8004005/diff/1/ppapi/cpp/graphics_3d.h
File ppapi/cpp/graphics_3d.h (right):

http://codereview.chromium.org/8004005/diff/1/ppapi/cpp/graphics_3d.h#newcode37
ppapi/cpp/graphics_3d.h:37: /// in <code>attrib_list</code>, then the default
value of 0 is used.
On 2011/10/11 15:46:52, jond wrote:
> On 2011/09/27 15:48:30, Alok Priyadarshi wrote:
> > Not all default vales are 0.
> 
> Please clarify. All seemed to have Default: 0 in the original file.
> 

For PP_GRAPHICS3DATTRIB_SWAP_BEHAVIOR, the default value is not 0.

[jond, 2011-10-17 21:32:04]

http://codereview.chromium.org/8004005/diff/1/ppapi/cpp/graphics_3d.h
File ppapi/cpp/graphics_3d.h (right):

http://codereview.chromium.org/8004005/diff/1/ppapi/cpp/graphics_3d.h#newcode37
ppapi/cpp/graphics_3d.h:37: /// in <code>attrib_list</code>, then the default
value of 0 is used.
On 2011/10/17 16:30:32, Alok Priyadarshi wrote:
> On 2011/10/11 15:46:52, jond wrote:
> > On 2011/09/27 15:48:30, Alok Priyadarshi wrote:
> > > Not all default vales are 0.
> > 
> > Please clarify. All seemed to have Default: 0 in the original file.
> > 
> 
> For PP_GRAPHICS3DATTRIB_SWAP_BEHAVIOR, the default value is not 0.

Done.

http://codereview.chromium.org/8004005/diff/1/ppapi/cpp/graphics_3d.h#newcode37
ppapi/cpp/graphics_3d.h:37: /// in <code>attrib_list</code>, then the default
value of 0 is used.
On 2011/10/17 16:30:32, Alok Priyadarshi wrote:
> On 2011/10/11 15:46:52, jond wrote:
> > On 2011/09/27 15:48:30, Alok Priyadarshi wrote:
> > > Not all default vales are 0.
> > 
> > Please clarify. All seemed to have Default: 0 in the original file.
> > 
> 
> For PP_GRAPHICS3DATTRIB_SWAP_BEHAVIOR, the default value is not 0.

Done.

[alokp1, 2011-10-17 21:33:34]

lgtm

[dmichael (off chromium), 2011-10-24 19:17:18]

rubber-stamp LGTM