Add Crankshaft support for smi-only elements

src/runtime.cc

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 425 matching lines @@
       is_cow ? elements : isolate->factory()->CopyFixedArray(elements);
 
   Handle<FixedArray> content = Handle<FixedArray>::cast(copied_elements);
   bool has_non_smi = false;
   if (is_cow) {
     // Copy-on-write arrays must be shallow (and simple).
     if (FLAG_smi_only_arrays) {
       for (int i = 0; i < content->length(); i++) {
         Object* current = content->get(i);
         ASSERT(!current->IsFixedArray());
-        if (!current->IsSmi()) {
+        if (!current->IsSmi() && !current->IsTheHole()) {
           has_non_smi = true;
         }
       }
     } else {
 #if DEBUG
       for (int i = 0; i < content->length(); i++) {
         ASSERT(!content->get(i)->IsFixedArray());
       }
 #endif
     }
   } else {
     for (int i = 0; i < content->length(); i++) {
       Object* current = content->get(i);
       if (current->IsFixedArray()) {
         // The value contains the constant_properties of a
         // simple object or array literal.
         Handle<FixedArray> fa(FixedArray::cast(content->get(i)));
         Handle<Object> result =
             CreateLiteralBoilerplate(isolate, literals, fa);
         if (result.is_null()) return result;
         content->set(i, *result);
         has_non_smi = true;
       } else {
-        if (!current->IsSmi()) {
+        if (!current->IsSmi() && !current->IsTheHole()) {
           has_non_smi = true;
         }
       }
     }
   }
 
   // Set the elements.
   Handle<JSArray> js_object(Handle<JSArray>::cast(object));
   isolate->factory()->SetContent(js_object, content);
 
@@ skipping 7762 matching lines @@
   CONVERT_ARG_CHECKED(JSFunction, function, 0);
   if (!function->IsOptimizable()) return isolate->heap()->undefined_value();
   function->MarkForLazyRecompilation();
   return isolate->heap()->undefined_value();
 }
 
 
 RUNTIME_FUNCTION(MaybeObject*, Runtime_GetOptimizationStatus) {
   HandleScope scope(isolate);
   ASSERT(args.length() == 1);
+  // The least significant bit (after untagging) indicates whether the
+  // function is currently optimized, regardless of reason.
   if (!V8::UseCrankshaft()) {
     return Smi::FromInt(4);  // 4 == "never".
   }
   if (FLAG_always_opt) {
     return Smi::FromInt(3);  // 3 == "always".
   }
   CONVERT_ARG_CHECKED(JSFunction, function, 0);
   return function->IsOptimized() ? Smi::FromInt(1)   // 1 == "yes".
                                  : Smi::FromInt(2);  // 2 == "no".
 }
@@ skipping 4943 matching lines @@
   } else {
     // Handle last resort GC and make sure to allow future allocations
     // to grow the heap without causing GCs (if possible).
     isolate->counters()->gc_last_resort_from_js()->Increment();
     isolate->heap()->CollectAllGarbage(Heap::kNoGCFlags);
   }
 }
 
 
 } }  // namespace v8::internal