Issue 8002005: Removed sending of the following IPC messages from chrome and added API's on the RenderViewHost

Issue 8002005: Removed sending of the following IPC messages from chrome and added API's on the RenderViewHost (Closed)

Created:
9 years, 3 months ago by ananta

Modified:
9 years, 3 months ago

Reviewers:
jam

CC:
chromium-reviews, Avi (use Gerrit), dpranke+watch-content_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Removed sending of the following IPC messages from chrome and added API's on the RenderViewHost object to facilitate this. 1. ViewMsg_CustomContextMenuAction 2. ViewMsg_ContextMenuClosed 3. ViewMsg_CopyImageAt 4. ViewMsg_MediaPlayerActionAt 5. ViewMsg_DisassociateFromPopupCount 6. ViewMsg_MoveOrResizeStarted 7. ViewMsg_StopFinding The ViewMsg_FindReplyACK message is now sent by the TabContents::OnFindReply handler. Continuing changes to get rid of the pattern of IPC messages being sent and processed across content and chrome. BUG=87335 . TEST=no change in functionality. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102404

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+240 lines, -186 lines)			Patch
M	chrome/browser/tab_contents/render_view_context_menu.cc	View	1 2	5 chunks	+6 lines, -10 lines	0 comments	Download
M	chrome/browser/ui/browser.cc	View	1 2 3	3 chunks	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/find_bar/find_tab_helper.cc	View	1	3 chunks	+2 lines, -11 lines	0 comments	Download
M	chrome/browser/ui/gtk/browser_window_gtk.cc	View		2 chunks	+1 line, -3 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_view.cc	View		2 chunks	+1 line, -3 lines	0 comments	Download
M	content/browser/renderer_host/render_view_host.h	View		4 chunks	+33 lines, -4 lines	0 comments	Download
M	content/browser/renderer_host/render_view_host.cc	View		1 chunk	+31 lines, -0 lines	0 comments	Download
M	content/browser/tab_contents/tab_contents.cc	View		1 chunk	+8 lines, -0 lines	0 comments	Download
A	content/common/view_message_enums.h	View	1 2 3	1 chunk	+154 lines, -0 lines	0 comments	Download
M	content/common/view_messages.h	View		2 chunks	+1 line, -152 lines	0 comments	Download
M	content/content_common.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jam

lgtm http://codereview.chromium.org/8002005/diff/1/content/common/view_message_enums.h File content/common/view_message_enums.h (right): http://codereview.chromium.org/8002005/diff/1/content/common/view_message_enums.h#newcode6 content/common/view_message_enums.h:6: // Multiply-included message file, hence no include guard. ...

9 years, 3 months ago (2011-09-22 21:50:55 UTC) #2

ananta

9 years, 3 months ago (2011-09-22 22:03:53 UTC) #3

http://codereview.chromium.org/8002005/diff/1/content/common/view_message_enu...
File content/common/view_message_enums.h (right):

http://codereview.chromium.org/8002005/diff/1/content/common/view_message_enu...
content/common/view_message_enums.h:6: // Multiply-included message file, hence
no include guard.
On 2011/09/22 21:50:55, John Abd-El-Malek wrote:
> nit: take out these comments

Done.

http://codereview.chromium.org/8002005/diff/1/content/common/view_message_enu...
content/common/view_message_enums.h:11: #include "base/basictypes.h"
On 2011/09/22 21:50:55, John Abd-El-Malek wrote:
> nit: not needed?

Done.

Expand Messages | Collapse Messages