Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1672)

Unified Diff: content/common/content_client.cc

Issue 8002003: Revert "Remove webkit_glue::BuildUserAgent(), change the contract in webkit_glue" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/content_client.h ('k') | content/renderer/renderer_glue.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/content_client.cc
diff --git a/content/common/content_client.cc b/content/common/content_client.cc
index 4622ce45b9607f812869637e6dccaca96588b6ef..cc2bad4677f6416418ddd65467ac01a78300d783 100644
--- a/content/common/content_client.cc
+++ b/content/common/content_client.cc
@@ -5,7 +5,6 @@
#include "content/common/content_client.h"
#include "base/string_piece.h"
-#include "webkit/glue/webkit_glue.h"
namespace content {
@@ -13,19 +12,6 @@ static ContentClient* g_client;
void SetContentClient(ContentClient* client) {
g_client = client;
-
- // TODO(dpranke): Doing real work (calling webkit_glue::SetUserAgent)
- // inside what looks like a function that initializes a global is a
- // bit odd, but we need to make sure this is done before
- // webkit_glue::GetUserAgent() is called (so that the UA doesn't change).
- //
- // It would be cleaner if we could rename this to something like a
- // content::Initialize(). Maybe we can merge this into ContentMain() somehow?
- if (client) {
- bool custom = false;
- std::string ua = client->GetUserAgent(&custom);
- webkit_glue::SetUserAgent(ua, custom);
- }
}
ContentClient* GetContentClient() {
« no previous file with comments | « content/common/content_client.h ('k') | content/renderer/renderer_glue.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698