Issue 7996008: Get views and views_unittests to build w/ use_aura=1

Issue 7996008: Get views and views_unittests to build w/ use_aura=1 (Closed)

Created:
9 years, 3 months ago by DaveMoore

Modified:
9 years, 3 months ago

Reviewers:
sadrul, sky

CC:
chromium-reviews, davemoore+watch_chromium.org, stevenjb, Paweł Hajdan Jr., nkostylev+cc_chromium.org, dhollowa, saintlou, oshima, Ben Goodger (Google)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

These are the changes necessary for views to be able to build w/ use_aura implying no gtk. BUG=97131 TEST=views_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102335

Patch Set 2 : Removed some chrome changes #

Total comments: 6

Patch Set 3 : Addressed review issues #

Total comments: 1

Patch Set 4 : Fixed review issue #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -39 lines)			Patch
M	build/build_config.h	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	build/common.gypi	View		2 chunks	+4 lines, -1 line	0 comments	Download
M	views/accelerator.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	views/controls/link.cc	View		3 chunks	+5 lines, -5 lines	0 comments	Download
M	views/controls/single_split_view.cc	View		3 chunks	+6 lines, -6 lines	0 comments	Download
M	views/controls/textfield/native_textfield_views_unittest.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	views/controls/textfield/textfield.h	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	views/controls/textfield/textfield.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	views/focus/accelerator_handler.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	views/mouse_watcher.cc	View	1 2 3	4 chunks	+11 lines, -6 lines	0 comments	Download
M	views/touchui/touch_factory.cc	View	1 2	5 chunks	+9 lines, -1 line	0 comments	Download
M	views/view.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	views/view_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	views/views.gyp	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	views/widget/widget_unittest.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	views/window/dialog_client_view.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

sadrul

http://codereview.chromium.org/7996008/diff/2001/build/common.gypi File build/common.gypi (right): http://codereview.chromium.org/7996008/diff/2001/build/common.gypi#newcode860 build/common.gypi:860: 'defines': ['TOOLKIT_USES_GTK=1'], Nice http://codereview.chromium.org/7996008/diff/2001/views/mouse_watcher.cc File views/mouse_watcher.cc (right): http://codereview.chromium.org/7996008/diff/2001/views/mouse_watcher.cc#newcode96 views/mouse_watcher.cc:96: ...

9 years, 3 months ago (2011-09-22 17:44:31 UTC) #2

DaveMoore

http://codereview.chromium.org/7996008/diff/2001/views/mouse_watcher.cc File views/mouse_watcher.cc (right): http://codereview.chromium.org/7996008/diff/2001/views/mouse_watcher.cc#newcode96 views/mouse_watcher.cc:96: void WillProcessEvent(GdkEvent* event) { On 2011/09/22 17:44:31, sadrul wrote: ...

9 years, 3 months ago (2011-09-22 18:03:07 UTC) #4

sadrul

9 years, 3 months ago (2011-09-22 18:06:32 UTC) #5

LGTM after the following is fixed.

http://codereview.chromium.org/7996008/diff/5001/views/mouse_watcher.cc
File views/mouse_watcher.cc (right):

http://codereview.chromium.org/7996008/diff/5001/views/mouse_watcher.cc#newco...
views/mouse_watcher.cc:96: void WillProcessEvent(XEvent* event) OVERRIDE {
WillProcessXEvent (note the X). Also the return type is different. This observer
also does not have DidProcessEvent to override.

Perhaps this block of could just doesn't need to be added?

Expand Messages | Collapse Messages