Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 7996005: compositor: Fix compositor_unittests build on Linux. (Closed)

Created:
9 years, 3 months ago by tfarina
Modified:
9 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

compositor: Fix compositor_unittests build on Linux. This makes compositor_unittests compiles on Linux. Although running it doesn't work yet because we return NULL in TestCompositorHost::Create() and it expects something different than NULL. R=sky@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102391

Patch Set 1 #

Total comments: 4

Patch Set 2 : sky review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M ui/gfx/compositor/compositor.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/compositor/layer_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A ui/gfx/compositor/test_compositor_host_linux.cc View 1 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tfarina
9 years, 3 months ago (2011-09-22 21:23:33 UTC) #1
sky
http://codereview.chromium.org/7996005/diff/1/ui/gfx/compositor/layer_unittest.cc File ui/gfx/compositor/layer_unittest.cc (right): http://codereview.chromium.org/7996005/diff/1/ui/gfx/compositor/layer_unittest.cc#newcode38 ui/gfx/compositor/layer_unittest.cc:38: color_index_ = color_index_ % static_cast<int>(colors_.size()); (color_index_ + 1) % ...
9 years, 3 months ago (2011-09-22 22:01:04 UTC) #2
tfarina
http://codereview.chromium.org/7996005/diff/1/ui/gfx/compositor/layer_unittest.cc File ui/gfx/compositor/layer_unittest.cc (right): http://codereview.chromium.org/7996005/diff/1/ui/gfx/compositor/layer_unittest.cc#newcode38 ui/gfx/compositor/layer_unittest.cc:38: color_index_ = color_index_ % static_cast<int>(colors_.size()); On 2011/09/22 22:01:05, sky ...
9 years, 3 months ago (2011-09-22 22:13:29 UTC) #3
sky
9 years, 3 months ago (2011-09-22 22:48:03 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698