net/socket/ssl_server_socket_nss.cc - Issue 7995009: net: fix crash when failing to import a client-side cert into NSS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/ssl_server_socket_nss.cc

Issue 7995009: net: fix crash when failing to import a client-side cert into NSS. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: ... Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/socket/ssl_server_socket_nss.cc

diff --git a/net/socket/ssl_server_socket_nss.cc b/net/socket/ssl_server_socket_nss.cc

index 78410f800c44a7914cd7a282425f1517744b9bed..8a2d2058decc1029839825635c31a72624bb7de6 100644

--- a/net/socket/ssl_server_socket_nss.cc

+++ b/net/socket/ssl_server_socket_nss.cc

@@ -369,6 +369,10 @@ int SSLServerSocketNSS::InitializeSSLOptions() {

// Parse into a CERTCertificate structure.

CERTCertificate* cert = CERT_NewTempCertificate(

CERT_GetDefaultCertDB(), &der_cert, NULL, PR_FALSE, PR_TRUE);

+ if (!cert) {

+ LogFailedNSSFunction(net_log_, "CERT_NewTempCertificate", "");

+ return ERR_UNEXPECTED;

wtc 2011/09/23 00:55:55 Let's return MapNSSError(PORT_GetError()) instead.

agl 2011/09/23 17:52:22 Done.

+ }

// Get a key of SECKEYPrivateKey* structure.

std::vector<uint8> key_vector;