Issue 7995002: Porting r9392 to arm (smi-only arrays).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7995002: Porting r9392 to arm (smi-only arrays). (Closed)

Created:
9 years, 3 months ago by Yang

Modified:
9 years, 3 months ago

Reviewers:
Rico

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Porting r9392 to arm (smi-only arrays). Committed: http://code.google.com/p/v8/source/detail?r=9411

Patch Set 1 #

Total comments: 2

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+121 lines, -25 lines)			Patch
M	src/arm/full-codegen-arm.cc	View	1 chunk	+13 lines, -3 lines	1 comment	Download
M	src/arm/ic-arm.cc	View	1 chunk	+14 lines, -0 lines	0 comments	Download
M	src/arm/macro-assembler-arm.h	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	src/arm/macro-assembler-arm.cc	View	1 chunk	+23 lines, -0 lines	0 comments	Download
M	src/arm/stub-cache-arm.cc	View	6 chunks	+59 lines, -22 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Rico

9 years, 3 months ago (2011-09-22 17:06:07 UTC) #2

LGTM, only nit

http://codereview.chromium.org/7995002/diff/1/src/arm/full-codegen-arm.cc
File src/arm/full-codegen-arm.cc (right):

http://codereview.chromium.org/7995002/diff/1/src/arm/full-codegen-arm.cc#new...
src/arm/full-codegen-arm.cc:1522: __ push(r6);
maybe a comment here:
__ push(r6);  // Copy of array literal

http://codereview.chromium.org/7995002/diff/1/src/arm/stub-cache-arm.cc
File src/arm/stub-cache-arm.cc (right):

http://codereview.chromium.org/7995002/diff/1/src/arm/stub-cache-arm.cc#newco...
src/arm/stub-cache-arm.cc:4365: elements_reg, Operand(FixedArray::kHeaderSize -
kHeapObjectTag));
Nit: move last argument to next line

Expand Messages | Collapse Messages