mac: Don't build with debug information on the trybots.

mac: Don't build with debug information on the trybots.

Locally, a full build is 50% faster with this.

BUG=none
TEST=mac trybot build time should go down at least 7 minutes.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102343

[Nico, 2011-09-22 17:46:55]

It looks like switching the commit queue to release builders helped win and
linux more than mac (but it helped everywhere):
http://build.chromium.org/p/tryserver.chromium/stats/

This should help somewhat.

[M-A Ruel, 2011-09-22 17:48:17]

lgtm

lgtm, thanks

[commit-bot: I haz the power, 2011-09-22 17:48:27]

CQ is trying tha patch. Follow status at
https://chromium-status.appspot.com/cq/thakis%40chromium.org/7994008/1

[Nicolas Sylvain, 2011-09-22 19:35:39]

nice.  How come we did not have that before :(

thanks Nico!

On Thu, Sep 22, 2011 at 10:46 AM, <thakis@chromium.org> wrote:

> Reviewers: Mark Mentovai,
>
> Message:
> It looks like switching the commit queue to release builders helped win and
> linux more than mac (but it helped everywhere):
>
http://build.chromium.org/p/**tryserver.chromium/stats/<http://build.chromium...
>
> This should help somewhat.
>
> Description:
> mac: Don't build with debug information on the trybots.
>
> Locally, a full build is 50% faster with this.
>
> BUG=none
> TEST=mac trybot build time should go down at least 7 minutes.
>
>
> Please review this at
http://codereview.chromium.**org/7994008/<http://codereview.chromium.org/7994...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M build/common.gypi
>
>
> Index: build/common.gypi
> diff --git a/build/common.gypi b/build/common.gypi
> index cdc02e002f88fc0fa70588ebcf4522**62e20bef4d..**
> 4321532ed26190ddb65c01398fefcd**6737592953 100644
> --- a/build/common.gypi
> +++ b/build/common.gypi
> @@ -900,8 +900,8 @@
>       ['fastbuild!=0', {
>
>         'conditions': [
> -          # For Windows, we don't genererate debug information.
> -          ['OS=="win"', {
> +          # For Windows and Mac, we don't genererate debug information.
> +          ['OS=="win" or OS=="mac"', {
>             'msvs_settings': {
>               'VCLinkerTool': {
>                 'GenerateDebugInformation': 'false',
> @@ -909,7 +909,10 @@
>               'VCCLCompilerTool': {
>                 'DebugInformationFormat': '0',
>               }
> -            }
> +            },
> +            'xcode_settings': {
> +              'GCC_GENERATE_DEBUGGING_**SYMBOLS': 'NO',
> +            },
>           }, { # else: OS != "win", generate less debug information.
>             'variables': {
>               'debug_extra_cflags': '-g1',
>
>
>

[Nico, 2011-09-22 19:54:27]

hamaji: fyi