Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 7993003: GC Cleanup + Set max old generation size to 700MB on ia32 and max executable size to 128 MB (on i... (Closed)

Created:
9 years, 3 months ago by Rico
Modified:
9 years, 3 months ago
CC:
v8-dev
Visibility:
Public.

Description

GC Cleanup + Set max old generation size to 700MB on ia32 and max executable size to 128 MB (on ia32) Committed: http://code.google.com/p/v8/source/detail?r=9406

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -23 lines) Patch
M src/heap.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/spaces.h View 1 2 2 chunks +1 line, -5 lines 0 comments Download
M src/spaces.cc View 1 2 1 chunk +0 lines, -9 lines 0 comments Download
M src/spaces-inl.h View 1 2 2 chunks +6 lines, -7 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Rico
http://codereview.chromium.org/7993003/diff/1/src/spaces-inl.h File src/spaces-inl.h (right): http://codereview.chromium.org/7993003/diff/1/src/spaces-inl.h#newcode255 src/spaces-inl.h:255: Address current_top = allocation_info_.top; This is only used below, ...
9 years, 3 months ago (2011-09-22 12:11:13 UTC) #1
Erik Corry
lgtm
9 years, 3 months ago (2011-09-22 12:33:05 UTC) #2
Rico
Added SKIP of mjsunit/regress/regress-524 since we go OOM on this. Issue 1719 created
9 years, 3 months ago (2011-09-22 15:45:41 UTC) #3
Vyacheslav Egorov (Chromium)
9 years, 3 months ago (2011-09-22 15:51:17 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698