Issue 7993001: Revert 102101 - Displaying the extensions count in extensions settings page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7993001: Revert 102101 - Displaying the extensions count in extensions settings page. (Closed)

Created:
9 years, 3 months ago by Finnur

Modified:
9 years, 3 months ago

Reviewers:
naveenbobbili

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, arv (Not doing code reviews), mihaip+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 102101 - Displaying the extensions count in extensions settings page. (Vetoed by the UI leads) BUG=96855 TEST=Load chrome://settings/extensionSettings and see that the title format is now Extensions (xx) where xx is the number of installed extensions in the list. Also if there are no extensions loaded then the title should be Extensions.Patch by naveenbobbili@motorola.comReview URL: http://codereview.chromium.org/7932021TBR=naveenbobbili@motorola.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102267

Patch Set 1 #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -17 lines)			Patch
M	AUTHORS	View	1 chunk	+0 lines, -1 line	0 comments	Download
MM	chrome/browser/resources/options/extension_settings.html	View	1 chunk	+2 lines, -3 lines	0 comments	Download
MM	chrome/browser/resources/options/extension_settings.js	View	1 chunk	+0 lines, -13 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Finnur

9 years, 3 months ago (2011-09-22 11:49:14 UTC) #2

Sorry about that. You've worked out how to contribute one patch, from start to
finish, so the next one will be easier.

You'll need to add yourself to the AUTHORS list again for your next patch.
Hopefully you'll have better luck next time. :)

Expand Messages | Collapse Messages